Update podspec Swift version to 5.0 to match project settings #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I had presumed this was setting the However, looks like the fix for this that covers all developers is: |
|
@owainhunt as 1.7.x is GA, please can you amend your PR to use the recommended guidance as per last comment. Thanks |
cocojoe
requested changes
Jun 17, 2019
|
Change made as requested. |
cocojoe
approved these changes
Jun 18, 2019
|
Looks good 👍 Have you tested it? |
|
Indeed, tested with Swift 4.2 and 5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Change to the Swift version specified in the podspec to version 5. This matches the project settings, and will prevent the 'Conversion to Swift 5 is available' warning showing in projects using the pod.
References
Not applicable
Testing
Config change only, no code changes.
Checklist