Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix padding issue in Tkinter grid by using a tuple #283

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

GLWine
Copy link
Contributor

@GLWine GLWine commented Nov 20, 2024

Description:

This PR fixes an issue with the use of the pady parameter in Tkinter widgets. Previously, a list ([5, 0]) was passed to define the vertical padding, but Tkinter expects a tuple. This change resolves the issue by using a tuple instead of a list, ensuring proper padding handling in the layout.

Key Changes:

  • Changed the pady parameter from a list to a tuple, from [5, 0] to (5, 0).

Why this change:

This change is required to ensure compatibility with Tkinter’s API, which expects pady (and similar parameters) to be passed as tuples, not lists.

Testing:

No additional tests are needed as this change only affects the layout handling in the Tkinter GUI.

References:

  • No specific issue, minor change to fix layout behavior.

In the 'WindowCMDRs' class, corrected padding values for labels by converting lists
into tuples. This resolves the issue where the 'pady' parameter was passed as a list
instead of a tuple, ensuring compatibility with Tkinter's grid system.

Changes made:
- Fixed 'pady' usage in 'CMDR Details' and 'Interaction' labels.
@aussig aussig merged commit 662e570 into aussig:develop Nov 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants