Add configurable history length #447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows servers to decide the max length of each history item they want to store! Some users might have much larger history lines than others. This setting can be set to 0 to allow for unlimited history length. This is not recommended for a public server install, but for a private one it can work nicely.
ellie
commented
Jun 10, 2022
| @@ -0,0 +1,2 @@ | |||
| -- Add migration script here | |||
| alter table history alter column data type text; | |||
There was a problem hiding this comment.
Text has no max size, unlike varchar
ellie
commented
Jun 10, 2022
| @@ -19,7 +19,7 @@ pub mod settings; | |||
| pub async fn launch(settings: Settings, host: String, port: u16) -> Result<()> { | |||
| let host = host.parse::<IpAddr>()?; | |||
|
|
|||
| let postgres = Postgres::new(settings.db_uri.as_str()) | |||
| let postgres = Postgres::new(settings.clone()) | |||
There was a problem hiding this comment.
Settings is also used below, and I'm lazy 🤐
ellie
commented
Jun 10, 2022
| @@ -33,6 +34,7 @@ impl Settings { | |||
| .set_default("host", "127.0.0.1")? | |||
| .set_default("port", 8888)? | |||
| .set_default("open_registration", false)? | |||
| .set_default("max_history_length", 8192)? | |||
There was a problem hiding this comment.
8192 is the old default set in the database schema, so behaviour does not change
conradludgate
previously approved these changes
Jun 10, 2022
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows servers to decide the max length of each history item they
want to store! Some users might have much larger history lines than
others.
This setting can be set to 0 to allow for unlimited history length. This
is not recommended for a public server install, but for a private one it
can work nicely.
Resolves #416