New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make server history item length configurable #416

Closed

ellie opened this issue May 17, 2022 · 0 comments · Fixed by #447

Member

ellie commented May 17, 2022

change https://github.com/ellie/atuin/blob/main/atuin-server/migrations/20210425153745_create_history.sql#L8 to a text, not a varchar. This will have no limit
add a history length here: https://github.com/ellie/atuin/blob/main/atuin-server/src/settings.rs#L11
check it when adding history here, error if too long: https://github.com/ellie/atuin/blob/main/atuin-server/src/handlers/history.rs#L75

I'll get to this soon, but also happy to help someone work on it :)

Some users have very large history items, and it would make things easier + more flexible if this were configurable

ellie mentioned this issue

Add configurable history length #447

Merged

ellie closed this as completed in #447

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment