Fix path watching by using nsfw v2 instead of @atom/nsfw
#76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This needs my Electron link update: atom/electron-link#27 |
aminya
force-pushed
the
master
branch
2 times, most recently
from
f3c93bd
to
e1645f5
Compare
aminya
force-pushed
the
master
branch
3 times, most recently
from
87c664d
to
67dcaef
Compare
aminya
force-pushed
the
master
branch
3 times, most recently
from
d5b2b31
to
1808785
Compare
Closed
|
It fixed the Windows-2019 test failures! 🎉 🎉 🎉 |
Yeah. 🙂 I knew this can fix it, that is why I decided to revive the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This uses the v2 of the original
nsfwpackage instead ofatom/nsfw. The newnsfwuse N-API and is being continuously maintained (unlike@atom/nsfwwhich has diverged from its upstream and has bugs lurking in it).This fixes the path watcher tests on Windows 2019.
Related Issues
Fixes #428
Closes #410
Background information about
@atom/nsfw: atom/nsfw#12 (comment)