Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the failing path watching Windows tests caused by Windows 2019 #428

Closed
aminya opened this issue Jul 4, 2022 · 0 comments · Fixed by #76
Closed

Fix the failing path watching Windows tests caused by Windows 2019 #428

aminya opened this issue Jul 4, 2022 · 0 comments · Fixed by #76
Labels
bug Something isn't working high-priority

Comments

@aminya
Copy link
Member

aminya commented Jul 4, 2022

Description

After switching to Windows 2019 in #408, some of our tests have started to fail. We should debug the issues and fix them. I suspect this is because Windows 2019 ships with a new Visual Studio C++ compiler and newer C++ standards by default.

Steps to Reproduce

See https://dev.azure.com/atomcommunity/atomcommunity/_build/results?buildId=1330&view=logs&jobId=f28c492c-c33f-521e-c0ca-e4634e70a589&j=f28c492c-c33f-521e-c0ca-e4634e70a589&t=a1ca5d4d-dde3-5878-7fb1-f5040f2451be

Expected behavior:

Actual behavior:

watchPath
  watchPath()
    it watchPath watchPath() reuses an existing native watcher on a parent directory and filters events
      timeout: timed out after 120000 msec waiting for spec promise to resolve
    it watchPath watchPath() adopts existing child watchers and filters events appropriately to them
      timeout: timed out after 120000 msec waiting for spec promise to resolve
Project
  .onDidChangeFiles()
    it Project .onDidChangeFiles() reports filesystem changes within project paths
      Error: Expired before all expected events were delivered.
        at expire (D:\a\1\s\spec\project-spec.js:1077:13)

Reproduces how often:

Always

Versions

Dev

Additional Information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working high-priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant