Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hints alignment x slot #3302

Closed
wants to merge 6 commits into from
Closed

Add hints alignment x slot #3302

wants to merge 6 commits into from

Conversation

aadcg
Copy link
Member

@aadcg aadcg commented Jan 2, 2024

Description

A follow-up to #3226.

Fixes #3179.
Fixes #3229.

Checklist:

  • Git branch state is mergable.
  • Changelog is up to date (via a separate commit).
  • New dependencies are accounted for.
  • Documentation is up to date.
  • Compilation and tests ((asdf:test-system :nyxt/gi-gtk))
    • No new compilation warnings.
    • Tests are sufficient.

@aadcg aadcg mentioned this pull request Jan 2, 2024
6 tasks
@aadcg aadcg force-pushed the add-hints-alignment-x-slot branch from 070be97 to 3a94e6e Compare January 3, 2024 12:38
@MaxGyver83
Copy link
Contributor

I have tested it and it works as expected.

A follow-up to #3236.

I think this is a typo and you wanted to refer to PR #3226.

@aadcg
Copy link
Member Author

aadcg commented Jan 3, 2024

@MaxGyver83 I have only rebased your work thus far. I'll add more commits soon and ping you for a review!

Thanks for the typo catch!

Set the horizontal alignment of the hints.
@aadcg aadcg force-pushed the add-hints-alignment-x-slot branch from 3a94e6e to 8bb914b Compare January 10, 2024 19:43
@aadcg aadcg force-pushed the add-hints-alignment-x-slot branch from 8bb914b to 8ebaf75 Compare January 10, 2024 19:55
@aadcg
Copy link
Member Author

aadcg commented Jan 10, 2024

I've refactored the work that @MaxGyver83 started in 1be0228, while retaining the commit.

I believe that it meets the users needs in the most general possible way while maximizing maintainability on the developer's side.

The draft, as it stands, breaks backwards compatibility so it won't make it for the 3-series. I don't think this feature is a priority so that's OK.

Looking for a first round of reviews on this draft to ensure that we're all on the same page. CC @MaxGyver83 @jmercouris. Then I'll polish it and make it ready to be merged.

Screenshots:

2024_01_10_21:40:56-nyxt

2024_01_10_21:42:23-nyxt

@jmercouris
Copy link
Member

Looks OK to me. Not sure what the magic number of -100 is, and why a font size of greater than 5 for that condition, but otherwise fine :-)

@aadcg aadcg closed this Jan 19, 2024
@aadcg aadcg deleted the add-hints-alignment-x-slot branch January 19, 2024 14:54
@aadcg aadcg mentioned this pull request Jan 19, 2024
5 tasks
@aadcg
Copy link
Member Author

aadcg commented Jan 19, 2024

Superseded by #3318 since the name of this branch is misleading.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants