-
-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hints alignment x slot #3302
Conversation
070be97
to
3a94e6e
Compare
@MaxGyver83 I have only rebased your work thus far. I'll add more commits soon and ping you for a review! Thanks for the typo catch! |
Set the horizontal alignment of the hints.
3a94e6e
to
8bb914b
Compare
8bb914b
to
8ebaf75
Compare
I've refactored the work that @MaxGyver83 started in 1be0228, while retaining the commit. I believe that it meets the users needs in the most general possible way while maximizing maintainability on the developer's side. The draft, as it stands, breaks backwards compatibility so it won't make it for the 3-series. I don't think this feature is a priority so that's OK. Looking for a first round of reviews on this draft to ensure that we're all on the same page. CC @MaxGyver83 @jmercouris. Then I'll polish it and make it ready to be merged. Screenshots: |
Looks OK to me. Not sure what the magic number of -100 is, and why a font size of greater than 5 for that condition, but otherwise fine :-) |
Superseded by #3318 since the name of this branch is misleading. |
Description
A follow-up to #3226.
Fixes #3179.
Fixes #3229.
Checklist:
(asdf:test-system :nyxt/gi-gtk)
)