Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Position hints next to links (instead of covering them) #3179

Closed
MaxGyver83 opened this issue Sep 19, 2023 · 6 comments · Fixed by #3318
Closed

Position hints next to links (instead of covering them) #3179

MaxGyver83 opened this issue Sep 19, 2023 · 6 comments · Fixed by #3318
Labels
feature Feature requests. hint-mode

Comments

@MaxGyver83
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Whenever I use hints, they cover the associated links (partly). The (not yet released) pull request #3173 allows the user to define pixel offsets for the hints. This is a great improvement but not ideal because the user has to find the right offset to have the hints next to the links via trial-and-error.

Describe the solution you'd like
It would be more user-friendly, if the user could choose if they want the hints to the left of a link, to the right of a link or on top of a link (current default).

Describe alternatives you've considered
None.

Additional context
Example of how it looks like in Firefox with the Surfingkeys add-on: Hints cover link text - Nyxt / Configuration Questions - Atlas

@MaxGyver83 MaxGyver83 added the feature Feature requests. label Sep 19, 2023
@aadcg
Copy link
Member

aadcg commented Sep 19, 2023

@MaxGyver83 out of curiosity, did you manage to find a good value for the offset? My understanding is that the right way to do this depends on the element being hinted.

@MaxGyver83
Copy link
Contributor Author

(define-configuration nyxt/mode/hint:hint-mode
  ((nyxt/mode/hint:hints-offset-x -45)))

This looks quite good for three-character hints:

2023-09-19 23 07 21 362x269 Region

But here it's too much:

2023-09-19 23 08 18 426x175 Region

Maybe it would be best to set something like the hint width + n pixels.

@jmercouris
Copy link
Member

it also depends on the styling of the page... it is not simple.

@aadcg
Copy link
Member

aadcg commented Sep 26, 2023

@MaxGyver83 if you're used to surfingkeys, try to add the following to your config:

(define-configuration nyxt/mode/hint:hint-mode
  ((nyxt/mode/hint:hinting-type :vi)))

@MaxGyver83
Copy link
Contributor Author

Thank you! I like this option.

@aadcg
Copy link
Member

aadcg commented Sep 27, 2023

It should be the default in my humble opinion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Feature requests. hint-mode
3 participants