Do not enforce logged user in Acl::getRules #92
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvorisek
changed the title
mvorisek
reviewed
Feb 25, 2022
| @@ -30,12 +30,6 @@ public function getRules(Model $model) | |||
| /** @var \Atk4\Login\Model\User */ | |||
| $user = $this->auth->user; | |||
|
|
|||
| if (!$user->isLoaded()) { | |||
There was a problem hiding this comment.
what do you expect from l38:
$res = $user->ref('AccessRules')->addCondition('model', 'in', $modelClasses);
returned then?
There was a problem hiding this comment.
here is a comparison of query issued by the l38 for logged & un-logged user:
mvorisek
requested changes
Mar 5, 2022
|
As this change is wrong and should even throw when traversing unloaded entity, I am closing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #90