Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assert no traversing on unloaded entity field #969

Merged
merged 6 commits into from
May 27, 2022

Conversation

mvorisek
Copy link
Member

@mvorisek mvorisek commented Feb 25, 2022

I consider traversing of unloaded entity as a bug, as no condition was added and all records were filtered

if no conditional reference is wanted, simply traverse on model instead of an entity

@mvorisek mvorisek force-pushed the assert_no_traversing_on_unloaded_entity branch from ffeb14a to 8844b21 Compare February 25, 2022 12:14
@mvorisek mvorisek changed the title Assert no traversing on unloaded entity Assert no traversing on unloaded entity field Feb 25, 2022
@mvorisek mvorisek force-pushed the assert_no_traversing_on_unloaded_entity branch 3 times, most recently from 79567cb to 1261157 Compare March 15, 2022 07:27
@mvorisek mvorisek force-pushed the assert_no_traversing_on_unloaded_entity branch from 1261157 to aa936e9 Compare May 9, 2022 08:54
@mvorisek mvorisek force-pushed the assert_no_traversing_on_unloaded_entity branch 4 times, most recently from 53e9746 to 5833347 Compare May 27, 2022 13:42
@mvorisek mvorisek force-pushed the assert_no_traversing_on_unloaded_entity branch from 95ad7c7 to 9144f17 Compare May 27, 2022 14:23
@mvorisek mvorisek marked this pull request as ready for review May 27, 2022 14:37
@mvorisek mvorisek force-pushed the assert_no_traversing_on_unloaded_entity branch from 1588ca9 to e0d88bd Compare May 27, 2022 15:19
@mvorisek mvorisek force-pushed the assert_no_traversing_on_unloaded_entity branch from 2ad2009 to 02eddca Compare May 27, 2022 15:26
@mvorisek mvorisek merged commit 05339b9 into develop May 27, 2022
@mvorisek mvorisek deleted the assert_no_traversing_on_unloaded_entity branch May 27, 2022 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant