Enhance Transactional Methods for Improved Request Queue Handling #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jchrys
force-pushed
the
1.0.x-respect-request-queue
branch
2 times, most recently
from
61db742
to
c0e65a6
Compare
Motivation: The current Transaction Methods implementation lacks consideration for the request queue, resulting in potential undefined behavior and issues. Modifications: Transaction Methods properly respect the request queue. Result: Bug resolved. Enhanced stability and reliability.
jchrys
force-pushed
the
1.0.x-respect-request-queue
branch
from
c0e65a6
to
f44427f
Compare
jchrys
changed the title
Motivation: The current Transaction Methods implementation lacks consideration for the request queue, resulting in potential undefined behavior and issues. Modifications: Transaction Methods properly respect the request queue. Result: Bug resolved. Enhanced stability and reliability.
mirromutth
approved these changes
Dec 22, 2023
There was a problem hiding this comment.
The current code does cause some problems and we should fix it.
I was thinking that transaction state is necessary, like ConnectionImpl#rollback() does, it even throws an exception if connection is not in a transaction.
Maybe we should check the state in RequestQueue instead, I created a ticket #183 for that. I think we can merge this PR first for fix the bug, and consider how to improve state checking (including other states).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The current Transaction Methods implementation lacks consideration for the request queue, resulting in potential undefined behavior and issues.
Modifications:
Transaction Methods properly respect the request queue.
Result:
Bug resolved.
Enhanced stability and reliability.