Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] States should be checked in queue #183

Closed
mirromutth opened this issue Dec 22, 2023 · 0 comments · Fixed by #185
Closed

[bug] States should be checked in queue #183

mirromutth opened this issue Dec 22, 2023 · 0 comments · Fixed by #185
Assignees
@jchrys
Labels
bug Something isn't working
Milestone
1.0.6/0.9.7

Comments

@mirromutth
Copy link
Contributor

mirromutth commented Dec 22, 2023 •
edited
Loading

Describe the bug

Currently, MySqlConnection checks transaction state between the Mono.defer is subscribed and Exchangeable is executed.

It may cause some undefined behavior. All states checking will have same problem, like MySqlConnection.isSessionAutoCommit.

I was thinking that transaction state is necessary, like ConnectionImpl#rollback() does, it even throws an exception if connection is not in a transaction.

Firstly, we should remove transaction state checking in MySqlConnection, see also #179 does.

Then we can consider adding proper status checks in Exchangeable and RequestQueue.

Expected behavior

States should be checked in RequestQueue executing Exchangeable instead.
This was referenced Dec 22, 2023
Merged
Merged
@mirromutth mirromutth added the bug Something isn't working label Dec 22, 2023
@mirromutth mirromutth changed the title [bug] Transaction state should be checked in queue [bug] States should be checked in queue Dec 22, 2023
@jchrys jchrys modified the milestones: 1.0.6/0.9.7, 1.1.0/0.10.0 Dec 22, 2023
@jchrys jchrys modified the milestones: 1.1.0/0.10.0, 1.0.6/0.9.7 Dec 29, 2023
jchrys added a commit that referenced this issue Dec 29, 2023
@jchrys
States should be checked in queue
4e10e12 
Motivation:
Currently, `MySqlConnection` checks state between the `Mono.defer` is subscribed and `Exchangeable` is executed. It may cause undefined behavior.

Modification:
Checks transaction state when request queue executes task.

Result:
Resolves #183

States should be checked in queue
jchrys added a commit that referenced this issue Dec 29, 2023
@jchrys
States should be checked in queue
27a3e79 
Motivation:
Currently, `MySqlConnection` checks state between the `Mono.defer` is subscribed and `Exchangeable` is executed. It may cause undefined behavior.

Modification:
Checks transaction state when request queue executes task.

Result:
Resolves #183
jchrys added a commit that referenced this issue Dec 29, 2023
@jchrys
States should be checked in queue
e1662a7 
Motivation:
Currently, `MySqlConnection` checks state between the `Mono.defer` is subscribed and `Exchangeable` is executed. It may cause undefined behavior.

Modification:
Checks transaction state when request queue executes task.

Result:
Resolves #183
jchrys added a commit that referenced this issue Dec 29, 2023
@jchrys
Transaction States Should Be Checked In Queue
eb7d65c 
Motivation:
Currently, `MySqlConnection` checks state between the `Mono.defer` is subscribed and `Exchangeable` is executed. It may cause undefined behavior.

Modification:
Checks transaction state when request queue executes task.

Result:
Resolves #183
@jchrys jchrys mentioned this issue Dec 29, 2023
Merged
jchrys added a commit that referenced this issue Jan 8, 2024
@jchrys
Transaction States Should Be Checked In Queue
10e4200 
Motivation:
Currently, `MySqlConnection` checks state between the `Mono.defer` is subscribed and `Exchangeable` is executed. It may cause undefined behavior.

Modification:
Checks transaction state when request queue executes task.

Result:
Resolves #183
@jchrys jchrys self-assigned this Jan 8, 2024
jchrys added a commit that referenced this issue Jan 9, 2024
@jchrys
Transaction States Should Be Checked In Queue
07199cb 
Motivation:
Currently, `MySqlConnection` checks state between the `Mono.defer` is subscribed and `Exchangeable` is executed. It may cause undefined behavior.

Modification:
Checks transaction state when request queue executes task.

Result:
Resolves #183
jchrys added a commit that referenced this issue Jan 10, 2024
@jchrys
Transaction States Should Be Checked In Queue
e182977 
Motivation:
Currently, `MySqlConnection` checks state between the `Mono.defer` is subscribed and `Exchangeable` is executed. It may cause undefined behavior.

Modification:
Checks transaction state when request queue executes task.

Result:
Resolves #183
@jchrys jchrys mentioned this issue Jan 10, 2024
Merged
jchrys added a commit that referenced this issue Jan 10, 2024
@jchrys
Transaction States Should Be Checked In Queue (#185)
aa4400b 
Motivation:
Currently, `MySqlConnection` checks state between the `Mono.defer` is
subscribed and `Exchangeable` is executed. It may cause undefined
behavior.

Modification:
Checks transaction state when request queue executes task.

Result:
Resolves #183
jchrys added a commit that referenced this issue Jan 10, 2024
@jchrys
Transaction States Should Be Checked In Queue (#189)
55ff20b 
Motivation:
Currently, `MySqlConnection` checks state between the `Mono.defer` is
subscribed and `Exchangeable` is executed. It may cause undefined
behavior.

Modification:
Checks transaction state when request queue executes task.

Result:
Resolves #183
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jchrys jchrys

Labels
bug Something isn't working
Projects
None yet
Milestone
1.0.6/0.9.7
Development

Successfully merging a pull request may close this issue.

Transaction States Should Be Checked In Queue asyncer-io/r2dbc-mysql
2 participants
@mirromutth @jchrys