-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bug] States should be checked in queue #183
Comments
This was referenced Dec 22, 2023
mirromutth
changed the title
[bug] Transaction state should be checked in queue
[bug] States should be checked in queue
Dec 22, 2023
jchrys
added a commit
that referenced
this issue
Dec 29, 2023
Motivation: Currently, `MySqlConnection` checks state between the `Mono.defer` is subscribed and `Exchangeable` is executed. It may cause undefined behavior. Modification: Checks transaction state when request queue executes task. Result: Resolves #183 States should be checked in queue
jchrys
added a commit
that referenced
this issue
Dec 29, 2023
Motivation: Currently, `MySqlConnection` checks state between the `Mono.defer` is subscribed and `Exchangeable` is executed. It may cause undefined behavior. Modification: Checks transaction state when request queue executes task. Result: Resolves #183
jchrys
added a commit
that referenced
this issue
Dec 29, 2023
Motivation: Currently, `MySqlConnection` checks state between the `Mono.defer` is subscribed and `Exchangeable` is executed. It may cause undefined behavior. Modification: Checks transaction state when request queue executes task. Result: Resolves #183
jchrys
added a commit
that referenced
this issue
Dec 29, 2023
Motivation: Currently, `MySqlConnection` checks state between the `Mono.defer` is subscribed and `Exchangeable` is executed. It may cause undefined behavior. Modification: Checks transaction state when request queue executes task. Result: Resolves #183
jchrys
added a commit
that referenced
this issue
Jan 8, 2024
Motivation: Currently, `MySqlConnection` checks state between the `Mono.defer` is subscribed and `Exchangeable` is executed. It may cause undefined behavior. Modification: Checks transaction state when request queue executes task. Result: Resolves #183
jchrys
added a commit
that referenced
this issue
Jan 9, 2024
Motivation: Currently, `MySqlConnection` checks state between the `Mono.defer` is subscribed and `Exchangeable` is executed. It may cause undefined behavior. Modification: Checks transaction state when request queue executes task. Result: Resolves #183
jchrys
added a commit
that referenced
this issue
Jan 10, 2024
Motivation: Currently, `MySqlConnection` checks state between the `Mono.defer` is subscribed and `Exchangeable` is executed. It may cause undefined behavior. Modification: Checks transaction state when request queue executes task. Result: Resolves #183
jchrys
added a commit
that referenced
this issue
Jan 10, 2024
Motivation: Currently, `MySqlConnection` checks state between the `Mono.defer` is subscribed and `Exchangeable` is executed. It may cause undefined behavior. Modification: Checks transaction state when request queue executes task. Result: Resolves #183
jchrys
added a commit
that referenced
this issue
Jan 10, 2024
Motivation: Currently, `MySqlConnection` checks state between the `Mono.defer` is subscribed and `Exchangeable` is executed. It may cause undefined behavior. Modification: Checks transaction state when request queue executes task. Result: Resolves #183
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Currently,
MySqlConnection
checks transaction state between theMono.defer
is subscribed andExchangeable
is executed.It may cause some undefined behavior. All states checking will have same problem, like
MySqlConnection.isSessionAutoCommit
.I was thinking that transaction state is necessary, like ConnectionImpl#rollback() does, it even throws an exception if connection is not in a transaction.
Firstly, we should remove transaction state checking in
MySqlConnection
, see also #179 does.Then we can consider adding proper status checks in
Exchangeable
andRequestQueue
.Expected behavior
States should be checked in
RequestQueue
executingExchangeable
instead.The text was updated successfully, but these errors were encountered: