Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add canonical metadata to blog #1458

Merged
merged 4 commits into from
Apr 4, 2023

Conversation

Ciggzy1312
Copy link
Contributor

@Ciggzy1312 Ciggzy1312 commented Mar 21, 2023

Description

  • Provide option to add canonical URL for blogs on npm run write:blog
  • Added <link rel=canonical href="https://solace.com/blog/asyncapi-vs-openapi/"/> to the head of the blogs having canonical URL
  • Mapped the canonical URLs for the blogs @jessemenning asked for

Related issue(s)
Fixes #1430

Signed-off-by: Deepayan Mukherjee <deepayanmukherjee1312@gmail.com>
@netlify
Copy link

netlify bot commented Mar 21, 2023

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 8246c5f
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/642b8c305f485d0008fd4196
😎 Deploy Preview https://deploy-preview-1458--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Mar 21, 2023

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 55
🟠 Accessibility 88
🟢 Best practices 92
🟢 SEO 100
🔴 PWA 30

Lighthouse ran on https://deploy-preview-1458--asyncapi-website.netlify.app/

@derberg derberg changed the title feat: added canonical metadata to blog feat: add canonical metadata to blog Mar 27, 2023
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏🏼

Thanks!!!

@derberg
Copy link
Member

derberg commented Mar 27, 2023

@alequetzalli please have a look, your approval is required

Copy link
Member

@quetzalliwrites quetzalliwrites left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@quetzalliwrites quetzalliwrites merged commit ba44c3f into asyncapi:master Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extends metadata of blog documents to enable people to provide canonical URL
3 participants