Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extends metadata of blog documents to enable people to provide canonical URL #1430

Closed
derberg opened this issue Mar 14, 2023 · 10 comments · Fixed by #1458
Closed

Extends metadata of blog documents to enable people to provide canonical URL #1430

derberg opened this issue Mar 14, 2023 · 10 comments · Fixed by #1458
Labels

Comments

@derberg
Copy link
Member

derberg commented Mar 14, 2023

Reason/Context

Some people repost important articles in AsyncAPI Blog. To encourage them to do that and promote their projects or educate community, then should know we will not abuse their original source, their original content and SEO of their blogging platform.

So we need to allow the author of an article to provide info what is the canonical URL, where is the original first version of the article.

Description

Best would be to support additional from matter filed in any document from https://github.com/asyncapi/website/tree/master/pages/blog.

so blog author can add:

title: `AsyncAPI vs OpenAPI` #already there, just an example
type: Engineering  #already there, just an example
canonical: https://solace.com/blog/asyncapi-vs-openapi/ #the new field we need

If canonical is provided, we need to make sure that resulting HTML has something like this in head:

<link rel=canonical href="https://solace.com/blog/asyncapi-vs-openapi/"/>

Nice to have is also to extend https://github.com/asyncapi/website/blob/master/scripts/compose.js script so when someone authors an article with npm run write:blog, the author is asked if there is a canonical URL for the article

@derberg
Copy link
Member Author

derberg commented Mar 14, 2023

/gfi js

@octonawish-akcodes
Copy link
Contributor

can I work on this :)

@jessemenning
Copy link
Contributor

@derberg thanks for opening this issue, it would definitely help me/others justify putting up blogs on asyncapi!

Copy link
Member Author

derberg commented Mar 15, 2023

@octonawish-akcodes go ahead please. Please include in the PR changes to @jessemenning articles where he needs the canonical URL.

@jessemenning can you provide if there are more articles affected than the one about AsyncAPI vs OpenAPI. There were some other articles from Solace folks afaik

@sambhavgupta0705
Copy link
Member

Hey @octonawish-akcodes ,are you still working on this issue?
If not then can I work on this one.

@octonawish-akcodes
Copy link
Contributor

octonawish-akcodes commented Mar 20, 2023

Yes I am working on this, will raise a PR soon :)

@Ciggzy1312
Copy link
Contributor

I have made a PR for this issue as I saw no one assigned and no activity on this issue for a week
But I just now noticed the latest comment

@derberg if you want me or if @octonawish-akcodes haven't made any progress on their side I can close my PR, don't want someone else's work to go to waste
Extremely sorry for not following up on the comments

@octonawish-akcodes
Copy link
Contributor

I have made the same changes and was going to raise the PR but no issue you can keep your PR.

@derberg
Copy link
Member Author

derberg commented Mar 27, 2023

Thanks folks for your commitment, just next time lets make sure you do not duplicate efforts 🙏🏼 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants