Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: codeblock and backticks styling #1401

Merged
merged 4 commits into from
Mar 9, 2023

Conversation

janvi01
Copy link
Contributor

@janvi01 janvi01 commented Mar 6, 2023

Description

fixed -

  1. code block style - padding around, color matching with markdown
  2. copy button bug of adding an unnecessary scrollbar as mentioned in the first point of Fix copy button position in docs command block #1292

new implementation screenshots -

when using code block -

Screenshot 2023-03-06 at 12 57 13 PM

when using backticks markdown-

Screenshot 2023-03-06 at 12 58 19 PM

copy button fix -

Screenshot 2023-03-06 at 1 08 00 PM

Screenshot 2023-03-06 at 1 08 19 PM

Fixes #1363

@netlify
Copy link

netlify bot commented Mar 6, 2023

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit a22cce4
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/6409cba195aba90008c6079f
😎 Deploy Preview https://deploy-preview-1401--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@janvi01 janvi01 changed the title fix: codeblock style fix: codeblock and backticks styling Mar 6, 2023
@github-actions
Copy link

github-actions bot commented Mar 6, 2023

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 38
🟠 Accessibility 88
🟢 Best practices 100
🟢 SEO 100
🔴 PWA 30

Lighthouse ran on https://deploy-preview-1401--asyncapi-website.netlify.app/

Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks very good, checked in browser and mobile

@akshatnema anything from your side?

@alequetzalli FYI, as it is docs rendering-related fix and you probably would like to know

@quetzalliwrites
Copy link
Member

looks good to me so far! knocks on wood 🚪

@akshatnema
Copy link
Member

/rtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CodeBlock is not consistent with regular markdown code
5 participants