fix: copy button and horizontal scrollbar position in codeblocks #1309
Conversation
janvi01
requested review from
quetzalliwrites,
asyncapi-bot-eve,
fmvilas,
derberg,
mcturco,
akshatnema and
magicmatatjahu
as code owners
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-1309--asyncapi-website.netlify.app/ |
There was a problem hiding this comment.
@janvi01 Based on the changes you made in the docs, they are not managed from this repository. For generator docs, the official documentation is maintained at generator repository. So, even if you change the backticks to the CodeBlock component, it will get rewrite once the workflow runs to update the docs in the website.
Also, you should ask first @alequetzalli whether all the Doc contributors will agree on using the <CodeBlock> component comfortably instead of backtick notation to write commands.
|
I don't think we can only use the codeblock element, I think we'll still use the ``` for some scenarios. Thoughts @derberg O_O? |
When using backticks, there is a misalignment of the copy button position. I don't know what is the reason, but when using the code block element it works well maybe we can find out why it is happening. |
|
@janvi01 @alequetzalli yup, we need a fix for both, the backticks and |
|
Closing this PR as this is not the appropriate solution, I have changed the backticks and codeblock css both in #1401 |
Description
The PR fixes the scrollbar position and misalignment of copy button in code blocks on various doc pages.
The misalignment was caused due to code blocks wrapped within backticks instead of the
codeblock.jscomponent.Screenshots -
Before
After
Related issue(s)
Fixes #1292