Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: updated AsyncAPI version on Parsers page #1344

Merged
merged 2 commits into from
Feb 22, 2023

Conversation

Arya-Gupta
Copy link
Contributor

@Arya-Gupta Arya-Gupta commented Feb 14, 2023

Fixes: #1331

AsyncAPI version on parsers page has been corrected.

@netlify
Copy link

netlify bot commented Feb 14, 2023

Deploy Preview for asyncapi-website ready!

Name Link
🔨 Latest commit 304ec9c
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/63f65592c9c28a0008622704
😎 Deploy Preview https://deploy-preview-1344--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Feb 14, 2023

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 46
🟠 Accessibility 88
🟢 Best practices 100
🟢 SEO 100
🔴 PWA 30

Lighthouse ran on https://deploy-preview-1344--asyncapi-website.netlify.app/

@akshatnema
Copy link
Member

Hey @Arya-Gupta 👋, thanks for creating the PR. Can you please also change the AsyncAPI version of the codeblocks used in the Docs, like for example , in Hello World Docs page- https://www.asyncapi.com/docs/tutorials/getting-started/hello-world.

@Arya-Gupta
Copy link
Contributor Author

Arya-Gupta commented Feb 14, 2023

Hey @akshatnema, I think @BhaswatiRoy was working on all the updates in the Docs section as a part of #1302. I found my bug in the Tools section. I'll still do it if you ask me to.

@akshatnema
Copy link
Member

Hey @akshatnema, I think @BhaswatiRoy was working on all the updates in the Docs section as a part of #1302. I found my bug in the Tools section. I'll still do it if you ask me to.

Thanks for pointing it out and informing me. Yeah, no need to replicate the changes at all of another PR.

Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@derberg
Copy link
Member

derberg commented Feb 22, 2023

/rtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[📑 Docs]: update AsyncAPI version on Parsers page
4 participants