Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Automate version in AsyncAPI docs #1567

Closed
Arya-Gupta opened this issue Apr 13, 2023 · 17 comments
Closed

feat: Automate version in AsyncAPI docs #1567

Arya-Gupta opened this issue Apr 13, 2023 · 17 comments

Comments

@Arya-Gupta
Copy link
Contributor

Reason/Context

Presently, AsyncAPI version needs to be updated manually across all documentation. This requires extra work and might lead to human errors. I suggest automating the version displayed across all documentation.

Description

Here is an example of such a version update.

@Arya-Gupta
Copy link
Contributor Author

Arya-Gupta commented Apr 13, 2023

Tagging @akshatnema, @derberg, and @alequetzalli for inputs.

@akshatnema
Copy link
Member

Regarding this, we can have a Spec Version variable (inside env) in the Netlify builds or a JSON file in the repository that handles these standard variables on all the pages on the website.

@derberg
Copy link
Member

derberg commented Apr 18, 2023

I like the idea. We should definitely not hide this info in any environment variables as this must be easy to update by anyone through PR. Maybe we could use fragments for it? 🤔

@derberg
Copy link
Member

derberg commented Apr 24, 2023

ok, fragments will not work, this update of version is needed not only in docs like https://github.com/asyncapi/website/blob/master/pages/docs/concepts/protocol.md but also JS files.

non, fragments nor env variables will really work 😞
I think the only option to do it manually

best would be to update release process instruction https://github.com/asyncapi/spec/blob/master/RELEASE_PROCESS.md#step-4---prepare-announcement-blog-post and require release coordinator to update version of asyncapi in website when release notes are created, in the same PR.

just short note, in what folders release coordinator should search for words 2.5.0 (previous release) and then update to latest.

thoughts?

@akshatnema
Copy link
Member

@derberg We can use the variables to assign the AsyncAPI version like this - https://www.coderrocketfuel.com/article/add-environment-variables-to-a-next-js-application. Then, if we are going to update the version of the AsyncAPI inside docs, you just need to change the value of this variable inside next.config.js file.

Copy link
Member

derberg commented May 11, 2023

but how does it work in markdown files? JS is not a problem

Copy link
Member

We can do this by initializing a component, which renders the environment variables on demand. So like, if we have to render the AsyncAPI version and the component name is Environment, so we can write as <Environment var="AsyncAPI_version" /> which will return process.env.[var] as the output.

Copy link
Member

derberg commented May 15, 2023

will this work in code snippets? this is where version is usually used. I don't think so

Copy link
Member

What do you mean by it will work in code snippets? I didn't get it. Do you want me to make a sample demo for this?

Copy link
Member

derberg commented May 17, 2023

Example: https://www.asyncapi.com/docs/tutorials/getting-started/hello-world

You have bunch of code snippets with YAML file, and AsyncAPI version mentioned in each. How will this <Environment var="AsyncAPI_version" /> work? or to be more precise, will it work?

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

Copy link

github-actions bot commented Mar 1, 2024

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Mar 1, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 30, 2024
@AnimeshKumar923
Copy link
Contributor

Still relevant? @derberg @akshatnema

@derberg
Copy link
Member

derberg commented Jul 15, 2024

Still relevant

@derberg derberg reopened this Jul 15, 2024
@github-actions github-actions bot removed the stale label Jul 16, 2024
@AayushSaini101
Copy link

@derberg @sambhavgupta0705 I am on it

Copy link

github-actions bot commented Dec 3, 2024

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Dec 3, 2024
@derberg
Copy link
Member

derberg commented Dec 16, 2024

no easy solution, still better to do ctrl+f on each release 🤷🏼

@derberg derberg closed this as completed Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants