fix: changed og_image #1147
fix: changed og_image #1147
Conversation
DivyanshuSonwal
requested review from
fmvilas,
derberg,
mcturco,
akshatnema,
magicmatatjahu and
asyncapi-bot-eve
as code owners
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-1147--asyncapi-website.netlify.app/ |
|
Hey @DivyanshuSonwal, that was fast. I have two comments though:
asyncapi: '2.3.0'
info:
title: Streetlights API
version: '1.0.0'
description: >
The Smartylighting Streetlights API allows you to... |
|
Sure, I will fix this. |
|
Please review now |
|
🤔 I just realized numbers are on the right-hand side now. Was it on purpose? |
No, it wasn't on purpose. Even I didn't notice it. I fixed it now, please take another look at it now. |
|
We should also update |
Are there any other changes also apart from this? |
DivyanshuSonwal
force-pushed
the
og_images
branch
from
1fda089 to
df5fc73
Compare
I have made the changes. |
There was a problem hiding this comment.
@fmvilas Do you wanna add something?
@DivyanshuSonwal Thanks for contribution!
@magicmatatjahu I’m glad I could contribute. |
|
/rtm |
There was a bug in previous homepage og-image and this pull request fixes that bug. #1146
@fmvilas