Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AsyncAPI example in the OpenGraph image contains an error #1146

Closed
fmvilas opened this issue Dec 7, 2022 · 3 comments · Fixed by #1147
Closed

AsyncAPI example in the OpenGraph image contains an error #1146

fmvilas opened this issue Dec 7, 2022 · 3 comments · Fixed by #1147
Labels
area/design Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. bug good first issue Good for newcomers

Comments

@fmvilas
Copy link
Member

fmvilas commented Dec 7, 2022 •
edited
Loading

Describe the bug

The OG image has an example AsyncAPI document in it. It contains an error. See the screenshots attached:

Captura de Pantalla 2022-12-07 a las 8 10 41
Captura de Pantalla 2022-12-07 a las 8 10 48

Expected behavior

The info object should be aligned with the asyncapi property. Also, there should be a > after the description: property, since it's multiline. Like this: description: >.

Resources

Here's the Figma file: https://www.figma.com/file/oXef38Ymd2s5FDqRQ5MRDr/OG-Images?node-id=2%3A29&t=feEULqctVnn5kzZI-1.

Feel free to ask for access if you don't have yet.
@fmvilas fmvilas added bug good first issue Good for newcomers area/design Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. labels Dec 7, 2022
@DivyanshuSonwal
Copy link
Contributor

I want to work on this issue. Could you please assign me this?

@sambhavgupta0705
Copy link
Member

Hey Can I work on this issue?

@AceTheCreator
Copy link
Member

Hey folks, we do not assign issues. If you're interested in fixing it, just do it and open a PR

@DivyanshuSonwal DivyanshuSonwal mentioned this issue Dec 7, 2022
Merged
@akshatnema akshatnema linked a pull request Dec 8, 2022 that will close this issue
fix: changed og_image #1147
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/design Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. bug good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: changed og_image DivyanshuSonwal/asyncapi_website
4 participants
@fmvilas @AceTheCreator @sambhavgupta0705 @DivyanshuSonwal