feat: hacktoberfest Blog Post #1131

AceTheCreator · 2022-11-28T17:01:41Z

I wrote a post summarising our participants at this year's Hacktoberfest

cc @derberg @alequetzalli

netlify · 2022-11-28T17:01:47Z

✅ Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name	Link
🔨 Latest commit	`072ebfb`
🔍 Latest deploy log	https://app.netlify.com/sites/asyncapi-website/deploys/6397ced65f96ca0009fe02b7
😎 Deploy Preview	https://deploy-preview-1131--asyncapi-website.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

github-actions · 2022-11-28T17:04:09Z

⚡️ Lighthouse report for the changes in this PR:

Category	Score
🔴 Performance	45
🟠 Accessibility	88
🟢 Best practices	100
🟢 SEO	100
🔴 PWA	30

Lighthouse ran on https://deploy-preview-1131--asyncapi-website.netlify.app/

magicmatatjahu · 2022-11-28T17:06:07Z

pages/blog/hacktoberfest-2022.md

+<table>
+  <tr>
+    <td align="center">
+      <a href="https://github.com/Amishakumari544">
+        <img src="https://avatars.githubusercontent.com/u/49230384?v=4" width="100px;" alt=""/>
+        <br />
+        <sub>
+          <b>
+            Amishakumari544 -  1 PR
+          </b>
+        </sub>
+      </a>
+    </td>


I don't wanna make review for md content (please wait for @alequetzalli), but maybe will be better to create React component for that, hmm, wdyt? 🤔

Maybe it should come in a separate PR?

separate PR is the biggest lie of a person on open source 😄 I'll fix it right away but in separate PR and PR will never be created XD That's only mu suggestion, you can create or not if you don't want. I don't have a problem with it.

I suggested this because I also have a post on the conference where I'll be giving a special shoutout to the volunteers and I'd eventually be listing them like the one above... So the PR will eventually be created 😄

OK, so PR will be (eventually) created, nice 😄

akshatnema

Sorry, I'm not a md reviewer 😅 , but I found some bugs inside the blog. Kindly go through it.

akshatnema · 2022-11-30T12:05:45Z

pages/blog/hacktoberfest-2022.md

@@ -0,0 +1,207 @@
+---
+title: "Is Hacktoberfest Good For Maintainers?"


Is this the correct title for this PR? 🤔 Because in the blog post, you are summarising Hacktoberfest 2022 in AsyncAPI.

yup, i think it is title of old existing article

I copied from the old one with updating in mind and I forgot 😄

pages/blog/hacktoberfest-2022.md

akshatnema · 2022-11-30T12:07:05Z

pages/blog/hacktoberfest-2022.md

@@ -0,0 +1,207 @@
+---
+title: "Is Hacktoberfest Good For Maintainers?"
+date: 2020-11-05T06:00:00+01:00


The date written is incorrect. Kindly change it.

akshatnema · 2022-11-30T12:11:13Z

pages/blog/hacktoberfest-2022.md

+
+<table>
+  <tr>
+    <td align="center">


The table created is scrollable in terms of responsiveness. I would you to use flexbox or make a separate component to show this content.

yo, why not just make a normal markdown table? O_O it's a good practice (unlike this current mess haha) and you don't need to build a new component 😄

👉🏽👉🏽 here's a simple tool to generate your markdown tables: https://www.tablesgenerator.com/markdown_tables

I feel using a component gives us more flexibility in terms of looks. Btw, I already created a PR

akshatnema · 2022-11-30T12:13:20Z

pages/blog/hacktoberfest-2022.md

+  <tr>
+    <td align="center">
+      <a href="https://github.com/Amishakumari544">
+        <img src="https://avatars.githubusercontent.com/u/49230384?v=4" width="100px;" alt=""/>


Suggested change

<img src="https://avatars.githubusercontent.com/u/49230384?v=4" width="100px;" alt=""/>

<img src="https://avatars.githubusercontent.com/Amishakumari544" width="100px;" alt=""/>

I think directly using Github username in the URL to show the profile photos is a better option.

derberg · 2022-12-01T09:47:58Z

Thanks so much for writing this up 🙏🏼

So feedback:

in case of @Mayaleeeee there were 4 PRs https://github.com/asyncapi/conference-website/pulls?q=is%3Apr+author%3AMayaleeeee are related to speaker cards
in case of @toukirkhan I think he did 2 PRs, one in website and one in bundler 🤔
in case of @Ankitchaudharyy I think there were 3 PRs

Maybe mention all the contributors in this article, so they can verify on their own. I mean specify how many hacktoberfest contributions they did

AceTheCreator · 2022-12-02T09:57:10Z

@Amishakumari544 @toukirkhan @manavdesai27 @Ankitchaudharyy @nawed2611 @dhfherna @amit-ksh @mastdev @codingtenshi @Mayaleeeee Please kindly confirm if the numbers of your PRs during hacktoberfest is right

toukirkhan · 2022-12-02T10:01:48Z

Yes mine is 2.

Ankitchaudharyy · 2022-12-02T10:18:04Z

I had 3 PR merged in hacktoberfest.

Amishakumari544 · 2022-12-02T10:19:37Z

@Amishakumari544 @toukirkhan @manavdesai27 @Ankitchaudharyy @nawed2611 @dhfherna @amit-ksh @mastdev @codingtenshi @Mayaleeeee Please kindly confirm if the numbers of your PRs during hacktoberfest is right

yes 🙌

amit-ksh · 2022-12-02T10:24:54Z

Yes, 1 PR merged during hacktoberfest

mastdev · 2022-12-02T10:32:31Z

@Amishakumari544 @toukirkhan @manavdesai27 @Ankitchaudharyy @nawed2611 @dhfherna @amit-ksh @mastdev @codingtenshi @Mayaleeeee Please kindly confirm if the numbers of your PRs during hacktoberfest is right

I worked on 2 PRs 188 and 275

Mayaleeeee · 2022-12-02T11:20:34Z

Yeahh
Mine is 4 @AceTheCreator

Co-authored-by: Alejandra Quetzalli <alejandra.quetzalli@postman.com>

Co-authored-by: Alejandra Quetzalli <alejandra.olvera.novack@gmail.com>

Co-authored-by: Lukasz Gornicki <lpgornicki@gmail.com> Co-authored-by: akshatnema <20bcs022@iiitdmj.ac.in>

Co-authored-by: Akshat Nema <76521428+akshatnema@users.noreply.github.com>

)

AceTheCreator · 2022-12-08T18:40:37Z

Updated the PR cc @alequetzalli @derberg

quetzalliwrites

❤️

pages/blog/hacktoberfest-2022.md

Co-authored-by: Lukasz Gornicki <lpgornicki@gmail.com>

derberg

we merge it tomorrow

akshatnema

approved 👍

akshatnema · 2022-12-13T04:34:14Z

/rtm

derberg · 2022-12-13T08:07:40Z

/rtm

AceTheCreator added 4 commits November 28, 2022 16:55

blog post about hacktoberfest 2022

b251413

completed hacktoberfest 2022 post

fe215cc

.

5479098

added hacktoberfest post

9d9cf36

AceTheCreator requested review from quetzalliwrites, asyncapi-bot-eve, fmvilas, derberg, mcturco, akshatnema and magicmatatjahu as code owners November 28, 2022 17:01

AceTheCreator changed the title ~~feat: Hacktoberfest Blog Post~~ feat: hacktoberfest Blog Post Nov 28, 2022

magicmatatjahu reviewed Nov 28, 2022

View reviewed changes

akshatnema requested changes Nov 30, 2022

View reviewed changes

AceTheCreator added 2 commits December 2, 2022 10:50

replaced avatar urls

9775510

updated PR counts

e652367

AceTheCreator mentioned this pull request Dec 2, 2022

feat: added new md component #1137

Merged

Merge branch 'master' into hack-post

9b923c4

quetzalliwrites assigned AceTheCreator Dec 2, 2022

quetzalliwrites added the Hacktoberfest Label issues as available for participants of https://hacktoberfest.digitalocean.com label Dec 2, 2022

AceTheCreator and others added 13 commits December 5, 2022 16:21

Update pages/blog/hacktoberfest-2022.md

74c5251

Co-authored-by: Alejandra Quetzalli <alejandra.quetzalli@postman.com>

Update pages/blog/hacktoberfest-2022.md

9816050

Co-authored-by: Alejandra Quetzalli <alejandra.quetzalli@postman.com>

Update pages/blog/hacktoberfest-2022.md

eba5a7d

Co-authored-by: Alejandra Quetzalli <alejandra.quetzalli@postman.com>

Update pages/blog/hacktoberfest-2022.md

b717a29

Co-authored-by: Alejandra Quetzalli <alejandra.quetzalli@postman.com>

Merge branch 'master' into hack-post

fdfbe25

docs: add protocol concepts doc (#1013)

fff23e1

Co-authored-by: Alejandra Quetzalli <alejandra.olvera.novack@gmail.com>

docs: new concept doc application (#992)

ab44f2f

Co-authored-by: Lukasz Gornicki <lpgornicki@gmail.com> Co-authored-by: akshatnema <20bcs022@iiitdmj.ac.in>

ci: update generic workflows (#1142)

842a41c

feat: added link to YT video to TSC page (#1141)

9a32bf0

Co-authored-by: Akshat Nema <76521428+akshatnema@users.noreply.github.com>

feat: added new md component (#1137)

5bb2194

Co-authored-by: Akshat Nema <76521428+akshatnema@users.noreply.github.com>

chore: add more categories for tools and support repo description (#1143

607f52e

)

chore: update meetings.json and newsrooom_videos.json (#1149)

ac42705

used the new md profile component

9998f68

Merge branch 'master' into hack-post

b9d1b8c

quetzalliwrites previously approved these changes Dec 10, 2022

View reviewed changes

derberg reviewed Dec 12, 2022

View reviewed changes

pages/blog/hacktoberfest-2022.md Outdated Show resolved Hide resolved

derberg requested a review from akshatnema December 12, 2022 12:25

Update pages/blog/hacktoberfest-2022.md

31e22d0

Co-authored-by: Lukasz Gornicki <lpgornicki@gmail.com>

AceTheCreator dismissed quetzalliwrites’s stale review via 31e22d0 December 12, 2022 12:26

Merge branch 'master' into hack-post

936d851

derberg approved these changes Dec 12, 2022

View reviewed changes

akshatnema approved these changes Dec 12, 2022

View reviewed changes

derberg requested a review from quetzalliwrites December 12, 2022 16:28

Merge branch 'master' into hack-post

072ebfb

quetzalliwrites approved these changes Dec 13, 2022

View reviewed changes

asyncapi-bot added the ready-to-merge label Dec 13, 2022

asyncapi-bot merged commit 61377cc into asyncapi:master Dec 13, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: hacktoberfest Blog Post #1131

feat: hacktoberfest Blog Post #1131

AceTheCreator commented Nov 28, 2022

netlify bot commented Nov 28, 2022 •

edited

Loading

github-actions bot commented Nov 28, 2022 •

edited

Loading

magicmatatjahu Nov 28, 2022

AceTheCreator Nov 28, 2022

magicmatatjahu Nov 28, 2022

AceTheCreator Nov 28, 2022

magicmatatjahu Nov 28, 2022 •

edited

Loading

akshatnema left a comment

akshatnema Nov 30, 2022

derberg Dec 1, 2022

AceTheCreator Dec 1, 2022

akshatnema Nov 30, 2022

akshatnema Nov 30, 2022

quetzalliwrites Dec 2, 2022

AceTheCreator Dec 5, 2022

akshatnema Nov 30, 2022

derberg commented Dec 1, 2022

AceTheCreator commented Dec 2, 2022

toukirkhan commented Dec 2, 2022 •

edited

Loading

Ankitchaudharyy commented Dec 2, 2022

Amishakumari544 commented Dec 2, 2022

amit-ksh commented Dec 2, 2022

mastdev commented Dec 2, 2022

Mayaleeeee commented Dec 2, 2022

AceTheCreator commented Dec 8, 2022

quetzalliwrites left a comment

derberg left a comment

akshatnema left a comment

akshatnema commented Dec 13, 2022

derberg commented Dec 13, 2022

		@@ -0,0 +1,207 @@
		---
		title: "Is Hacktoberfest Good For Maintainers?"

	<img src="https://avatars.githubusercontent.com/u/49230384?v=4" width="100px;" alt=""/>
	<img src="https://avatars.githubusercontent.com/Amishakumari544" width="100px;" alt=""/>

feat: hacktoberfest Blog Post #1131

feat: hacktoberfest Blog Post #1131

Conversation

AceTheCreator commented Nov 28, 2022

netlify bot commented Nov 28, 2022 • edited Loading

✅ Deploy Preview for asyncapi-website ready!

github-actions bot commented Nov 28, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

magicmatatjahu Nov 28, 2022 • edited Loading

Choose a reason for hiding this comment

akshatnema left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

derberg commented Dec 1, 2022

AceTheCreator commented Dec 2, 2022

toukirkhan commented Dec 2, 2022 • edited Loading

Ankitchaudharyy commented Dec 2, 2022

Amishakumari544 commented Dec 2, 2022

amit-ksh commented Dec 2, 2022

mastdev commented Dec 2, 2022

Mayaleeeee commented Dec 2, 2022

AceTheCreator commented Dec 8, 2022

quetzalliwrites left a comment

Choose a reason for hiding this comment

derberg left a comment

Choose a reason for hiding this comment

akshatnema left a comment

Choose a reason for hiding this comment

akshatnema commented Dec 13, 2022

derberg commented Dec 13, 2022

netlify bot commented Nov 28, 2022 •

edited

Loading

github-actions bot commented Nov 28, 2022 •

edited

Loading

magicmatatjahu Nov 28, 2022 •

edited

Loading

toukirkhan commented Dec 2, 2022 •

edited

Loading