chore: add more categories for tools and support repo description #1143
Conversation
derberg
requested review from
fmvilas,
mcturco,
akshatnema,
magicmatatjahu and
asyncapi-bot-eve
as code owners
✅ Deploy Preview for asyncapi-website ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-1143--asyncapi-website.netlify.app/ |
| @@ -78,10 +79,10 @@ async function convertTools(data) { | |||
| } | |||
| }); | |||
| } else { | |||
| console.error('Script is not failing, it is just dropping errors for further investigation'); | |||
There was a problem hiding this comment.
moved it up as when I was testing it locally, it was strange to see this at the end of logs, not intuitive.
|
@akshatnema ok, I added few more tools files and this is why I created this PR. |
scripts/tools/tools-object.js
Outdated
| let resultantObject = { | ||
| title: toolFile.title, | ||
| description: toolFile.description, | ||
| description: repoDescription || toolFile.description, |
There was a problem hiding this comment.
My query is what if there are certain repos whose descriptions are not precise enough to show them to readers? There can be the case that the owner of the tool wants to make a custom description for its tool to show up in the dashboard. Then this will create problems.
There was a problem hiding this comment.
What problems? If someone will want to precise description will have to write description in the config file. I don't see any problems 😅
There was a problem hiding this comment.
Even if someone writes the description, it won't be considered with this implementation as it will only take the description mentioned in the GitHub repository.
There was a problem hiding this comment.
Ahh yes, It should be:
toolFile.description || repoDescription,
|
fixed, and also updated generated files, the last PR I did was updated, so I already updated generated json files |
|
@akshatnema I see @magicmatatjahu approved but I will not merge without your approval 😏 |
Sorry, I was taking my dinner at that time. Will approve now 😄 |
|
/rtm |
.asyncapi-toolsfile to a few more repos and some categories were missingdescriptionoptional as we should read GitHub repo description firstlinksoptional as might be there are no links to provide for the project