refactor: changing input processor and interpreter to support more schemas #377
Conversation
# Conflicts: # package-lock.json
…o feature/refactor_input # Conflicts: # src/interpreter/Interpreter.ts # src/models/index.ts # src/processors/JsonSchemaInputProcessor.ts
Pull Request Test Coverage Report for Build 1261433956
💛 - Coveralls |
|
@magicmatatjahu we can ignore the bug as #379 removes it. |
There was a problem hiding this comment.
@jonaslagoni I understand that we are still sticking with CommonModel etc? Will this be changed in the future?
Refactored the toX functions for Draft7Schema and CommonModel to be more generic, I did not find any way to generalize it anymore between them, so if you have any suggestion, let me know 🙏
It seems like too much boilerplate to me, but it would take a lot of work to change it and that's the easiest way to do it now... 😅
Also, you have one bug in sonar cloud.
# Conflicts: # package-lock.json
|
Kudos, SonarCloud Quality Gate passed!
|
@magicmatatjahu for now, however I have started to rework that part, but it is a WIP, as I still need test different things before making some noise around it - #365 (comment)
Yea, exactly, dont have any better alternative at the moment. At least I dont see it. |
|
🎉 This PR is included in version 0.31.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
As more input schemas are to be supported, we need to split out the schemas even more than we are now.
The changes:
SchemaandCommonSchemacompletely and introduces the more specificDraft7SchemaandAsyncapiV2Schema.originalSchemaproperty from theCommonModeltooriginalInput- see originalSchema for CommonModel should be called originalInput #86toXfunctions forDraft7SchemaandCommonModelto be more generic, I did not find any way to generalize it anymore between them, so if you have any suggestion, let me know 🙏Related issue(s)
Related to #360
Fixes #86