Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swagger / OpenAPI input #360

Closed
voxpelli opened this issue Sep 6, 2021 · 16 comments · Fixed by #381
Closed

Swagger / OpenAPI input #360

voxpelli opened this issue Sep 6, 2021 · 16 comments · Fixed by #381
Labels
enhancement New feature or request keep Dont let stale get to it. stale

Comments

@voxpelli
Copy link

voxpelli commented Sep 6, 2021

Reason/Context

Please try answering few of those questions

  • Why we need this improvement?
    • Swagger / OpenAPI is very similar to AsyncAPI and also builds upon JSON Schema style model definitions
  • How will this change help?
    • Enable more types of conversions and a more complete toolchain for models of all types of sources.

Description

Please try answering few of those questions

  • What changes have to be introduced?
    • Probably the same that was needed to support AsyncAPI on top of JSON Schema
  • Will this be a breaking change?
    • Nope
  • How could it be implemented/designed?
    • Probably the same way that AsyncAPI was
@voxpelli voxpelli added the enhancement New feature or request label Sep 6, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2021

Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.

Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@voxpelli voxpelli mentioned this issue Sep 6, 2021
@jonaslagoni
Copy link
Member

Just leaving this for later:

@jonaslagoni
Copy link
Member

jonaslagoni commented Sep 23, 2021

@voxpelli do you by any chance have any Swagger/OpenAPI documents you can share, that I can test with? 🙂

Also, do you mind if I ping you, to review the features once they are complete?

@voxpelli
Copy link
Author

@jonaslagoni Unfortunately nothing public, but I do remember the file I was looking at this time as being a Swagger 2.0 file, so #378 would solve it.

Please ping me when you want a review!

@jonaslagoni
Copy link
Member

@voxpelli the PR is ready from our side to be merged, if you want to give your review, now is the time 😄 Let me know if you don't have time to review it, so we don't wait in vain 👍

I suggest to download the branch and adapt the example to fit your need - https://github.com/jonaslagoni/generator-model-sdk/tree/feature/swagger_new/examples/swagger2.0-from-object

@asyncapi-bot
Copy link
Contributor

🎉 This issue has been resolved in version 0.38.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@jonaslagoni
Copy link
Member

jonaslagoni commented Oct 12, 2021

Accidentally closed, as we still need to support OpenAPI 3.1, however, I will not focus on this in the near future, if anyone is up to the task, ping me if you want any help 🙂

@jonaslagoni jonaslagoni reopened this Oct 12, 2021
@jonaslagoni jonaslagoni removed this from the Version 1.0.0 milestone Oct 12, 2021
@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Mar 23, 2022
@voxpelli
Copy link
Author

Still relevant :)

@github-actions github-actions bot removed the stale label Mar 24, 2022
@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added stale and removed stale labels Jul 30, 2022
@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Nov 30, 2022
@voxpelli
Copy link
Author

Still relevant :)

@jonaslagoni jonaslagoni added keep Dont let stale get to it. and removed stale labels Nov 30, 2022
@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Mar 31, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 13, 2024
@AnimeshKumar923
Copy link

still valid? @jonaslagoni @voxpelli

@voxpelli
Copy link
Author

I guess this still holds true:

still need to support OpenAPI 3.1

But maybe better to add that as a new issue? To make it clearer?

@jonaslagoni
Copy link
Member

Lets keep this closed and focus on #1749 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request keep Dont let stale get to it. stale
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants