-
-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OpenAPI 3.1 support #1749
Comments
Hey @jonaslagoni after making changes i can test this in the playground right? |
Cant remember if playground allows multiple inputs yet. You can write unit tests for it 😄 |
Hello @jonaslagoni, I'm eager to contribute to this issue and excited to make my first open-source contribution. As a newcomer, I would greatly appreciate some guidance on the task. Upon inspecting the OpenAPIInputProcessor.ts file, it appears that the current parser used by the project lacks support for parsing and validating OpenAPI 3.1 specifications. After some research, I came across a repository based on apidevtools/swagger-parser. I believe integrating this alternative parser could address the gap in OpenAPI 3.1 support. I'm ready to explore and contribute to implementing this improvement. Any guidance or pointers you can provide would be immensely helpful. |
Sounds like a good idea @Tanay-Verma 👍 |
We currently aren't using the latest version of the swagger-parser. The latest version of it has support for the OpenAPI 3.1 version as well. |
Sounds even better @Athul0491, @Tanay-Verma 👍 |
Is this the one you are referring swagger-parser? |
@Tanay-Verma I was referring to swagger-parser. See this, they have added support for OpenAPI 3.1 in version |
@Athul0491 @jonaslagoni |
Either that or update the existing one for v3 with v3.1 changes as they should be non breaking |
🎉 This issue has been resolved in version 3.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This issue has been resolved in version 4.0.0-next.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Reason/Context
Right now we already have support for OpenAPI 3.0 and Swagger 2.0. But we should also support the newest 3.1 version: https://github.com/OAI/OpenAPI-Specification/blob/main/versions/3.1.0.md
To support it we need to alter the existing OpenAPI input processor to also support the new 3.1 version: https://github.com/asyncapi/modelina/blob/master/src/processors/OpenAPIInputProcessor.ts
This does
You can use the following OpenAPI 3.1 input document for testing (or come up with your own):
Happy to help further if you get stuck on something ✌️
The text was updated successfully, but these errors were encountered: