Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add community files #4

Merged
merged 3 commits into from
Apr 14, 2021

Conversation

jonaslagoni
Copy link
Member

@jonaslagoni jonaslagoni commented Apr 13, 2021

Description
This PR adds all the files from https://github.com/asyncapi/.github/
Requested in #3 (comment)
@derberg I guess you have to set up some extra things afterward?

@jonaslagoni jonaslagoni requested a review from derberg April 13, 2021 09:22
@derberg
Copy link
Member

derberg commented Apr 13, 2021

no need to move templates, they are supported by .github functionality, meaning they can be stored only in .github repo and will work in all repos that do not have own templates, just have a look https://github.com/asyncapi/cli/issues/new/choose

workflows just need to be copied, they would be already but I have one bug that I need to solve in my global workflows action

@jonaslagoni
Copy link
Member Author

jonaslagoni commented Apr 13, 2021

no need to move templates, they are supported by .github functionality, meaning they can be stored only in .github repo and will work in all repos that do not have own templates, just have a look https://github.com/asyncapi/cli/issues/new/choose

@derberg removed.

workflows just need to be copied, they would be already but I have one bug that I need to solve in my global workflows action

So you have a blocker which prevents us from adding the workflow files as they are now? 🤔

@derberg
Copy link
Member

derberg commented Apr 14, 2021

@jonaslagoni no, I just mean that now you create those files manually, but since we created CLI repo, there were some updates in global workflows that were not pushed here due to my bug.

Normally, you would have to copy those files anyway if you would like to have them right after creating the repo (like in robot)

you can merge

@jonaslagoni jonaslagoni merged commit 38b6466 into asyncapi:master Apr 14, 2021
@jonaslagoni jonaslagoni deleted the feature/github_actions branch April 14, 2021 09:29
peter-rr pushed a commit to peter-rr/cli that referenced this pull request Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants