-
-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
setting up commands #3
Conversation
@jonaslagoni can we add codacy checks here for code quality ?
|
@GouravSardana definitely, I would suggest you add a linter as well from the start - similar to https://github.com/asyncapi/parser-js/blob/2b1d06fef5600caf4893638c58b568fe8d71ced4/package.json#L19, we learned it the hard way and had to refactor a bunch last implementation cycle😄. I will add a PR for the GitHub actions. |
yes, eslint for static code analysis, |
@Souvikns we do not want to use commander but https://github.com/vadimdemedes/ink, we use commander in current generator CLI, but want better user experience that Ink can bring. @jotamusik is working on introducing it. @jotamusik looking at the interest from the community, maybe you could already open a PR, even if not yet ready, folks that want to help could already jump in and provide feedback, what do you think? |
Okey! I will do it this afternoon! :P |
* feat: add POC for measuring adoption * Update convert command * Add metrics recording to some commands * Add new metric recording for action invocation * Add new metric recording for another command * Reduce metrics recording code --------- Co-authored-by: Sergio Moya <1083296+smoya@users.noreply.github.com>
Description
Related issue(s)
#1