Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setting up commands #3

Closed
wants to merge 8 commits into from
Closed

setting up commands #3

wants to merge 8 commits into from

Conversation

Souvikns
Copy link
Member


Still not complete figuring out all the commands


Description

  • Just installed commander and had set it up

Related issue(s)
#1

@Souvikns Souvikns changed the title Init setting up commands Apr 12, 2021
@GouravSardana
Copy link

@jonaslagoni can we add codacy checks here for code quality ?

  • Add sonar cloud bot too. It will be easy for us to maintain the code quality from starting ;)

@jonaslagoni
Copy link
Member

jonaslagoni commented Apr 13, 2021

@jonaslagoni can we add codacy checks here for code quality ?

* Add sonar cloud bot too. It will be easy for us to maintain the code quality from starting ;)

@GouravSardana definitely, I would suggest you add a linter as well from the start - similar to https://github.com/asyncapi/parser-js/blob/2b1d06fef5600caf4893638c58b568fe8d71ced4/package.json#L19, we learned it the hard way and had to refactor a bunch last implementation cycle😄. I will add a PR for the GitHub actions.

@derberg
Copy link
Member

derberg commented Apr 13, 2021

yes, eslint for static code analysis,
sonar cloud enabled just now

@derberg
Copy link
Member

derberg commented Apr 13, 2021

@Souvikns we do not want to use commander but https://github.com/vadimdemedes/ink, we use commander in current generator CLI, but want better user experience that Ink can bring. @jotamusik is working on introducing it.

@jotamusik looking at the interest from the community, maybe you could already open a PR, even if not yet ready, folks that want to help could already jump in and provide feedback, what do you think?

@Souvikns
Copy link
Member Author

@derberg ok so let me read ink and then can update the pr.

@jotamusik
Copy link
Contributor

jotamusik commented Apr 13, 2021

@jotamusik looking at the interest from the community, maybe you could already open a PR, even if not yet ready, folks that want to help could already jump in and provide feedback, what do you think?

Okey! I will do it this afternoon! :P

@Souvikns Souvikns closed this Apr 23, 2021
peter-rr added a commit to peter-rr/cli that referenced this pull request Nov 28, 2023
* feat: add POC for measuring adoption

* Update convert command

* Add metrics recording to some commands

* Add new metric recording for action invocation

* Add new metric recording for another command

* Reduce metrics recording code

---------

Co-authored-by: Sergio Moya <1083296+smoya@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants