Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added models and rpc calls for notification service #39

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

pranjal-astuto
Copy link
Contributor

@pranjal-astuto pranjal-astuto commented Nov 21, 2024

Summary by CodeRabbit

  • New Features

    • Introduced new enums for notification types and entities to enhance ticket notification handling.
    • Added classes for ticket notification requests and responses to streamline notification processes.
    • Implemented a new service handler for sending ticket notifications via an API.
  • Bug Fixes

    • Updated existing classes to include optional fields for improved notification attributes.
  • Documentation

    • Enhanced module interface by updating the public API to include the new notification service handler.

Copy link

coderabbitai bot commented Nov 21, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The changes introduce new classes and enumerations to enhance the notification system for ticket events in the onelens_backend_client_v2/models.py file. Key additions include NotificationEntityType, NotificationType, TicketNotificationRequest, and TicketNotificationResponse. A new class, NotificationServiceRpcHandler, is added in notification_service_rpc_handler.py, which provides an API for sending notifications. The __init__.py file is updated to include this new handler in the module's public API.

Changes

File Path Change Summary
onelens_backend_client_v2/models.py - Added enums: NotificationEntityType, NotificationType
- Added classes: TicketNotificationRequest, TicketNotificationResponse
- Updated existing classes to include optional fields for notifications.
onelens_backend_client_v2/rpc/__init__.py - Added NotificationServiceRpcHandler to __all__ list.
onelens_backend_client_v2/rpc/notification_service_rpc_handler.py - Added class: NotificationServiceRpcHandler
- Added method: send_ticket_notification
- Added method: _send_ticket_notification_serialize.

Suggested reviewers

  • kaushikkishore

Poem

In the meadow where tickets bloom,
Notifications dance, dispelling gloom.
New enums hop, and classes play,
Sending alerts in a joyful way.
With a twitch of my nose, I cheer with delight,
For changes so bright, they light up the night! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@pranjal-astuto pranjal-astuto merged commit 61d0418 into main Nov 21, 2024
1 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant