Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated python client #38

Merged
merged 1 commit into from
Nov 20, 2024
Merged

updated python client #38

merged 1 commit into from
Nov 20, 2024

Conversation

pranjal-astuto
Copy link
Contributor

@pranjal-astuto pranjal-astuto commented Nov 20, 2024

Summary by CodeRabbit

  • New Features

    • Introduced new classes for enhanced ticket activity tracking, including FormattedTicketActivity and InsertTicketActivitiesRequest.
    • Added methods in the new TenantTicketActivityServiceRpcHandler for managing ticket activities, including get_formatted_activities and insert_activities.
  • Bug Fixes

    • Improved error handling and response validation for ticket activity methods.
  • Documentation

    • Updated method names and docstrings for clarity in the TenantTicketAuditServiceRpcHandler.
  • Refactor

    • Removed unused classes and streamlined the model structure for better data integrity.

Copy link

coderabbitai bot commented Nov 20, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The changes in this pull request involve significant updates to the onelens_backend_client_v2/models.py file, including the addition of new classes for managing ticket activities and modifications to existing class attributes to enhance data handling. Additionally, the onelens_backend_client_v2/rpc/__init__.py file has been updated to remove an unused RPC handler and include a new one. A new file, tenant_ticket_activity_service_rpc_handler.py, has been introduced, providing methods for handling ticket activity requests. Lastly, the TenantTicketAuditServiceRpcHandler class has been modified to improve method naming and clarity.

Changes

File Change Summary
onelens_backend_client_v2/models.py Added classes: FormattedTicketActivity, DailyFormattedActivities, InsertTicketActivitiesRequest, InsertTicketActivitiesResponse, GetFormattedTicketActivitiesApiResponse. Updated user_id fields to UUID4 in several classes. Removed classes: Column, ExampleQuery, TableType. Updated GetAllFeaturesResponse and GetAllUsersResponse.
onelens_backend_client_v2/rpc/__init__.py Removed import of NaviraResourceExplorerServiceRpcHandler, added TenantTicketActivityServiceRpcHandler. Updated __all__ declaration accordingly.
onelens_backend_client_v2/rpc/tenant_ticket_activity_service_rpc_handler.py Added TenantTicketActivityServiceRpcHandler class with methods: get_formatted_activities and insert_activities.
onelens_backend_client_v2/rpc/tenant_ticket_audit_service_rpc_handler.py Renamed method get to get_tenant_ticket_audit and updated internal serialization method to _get_tenant_ticket_audit_serialize.

Possibly related PRs

  • added recreate hierarchy mappings #26: The changes in onelens_backend_client_v2/models.py involve significant modifications to class structures and attributes, which may relate to the overall model updates in the main PR.
  • Updated the python client model #30: This PR also updates onelens_backend_client_v2/models.py with new classes and modifications to existing ones, indicating a potential overlap in the model changes.
  • Updated python client #32: Similar to the previous PRs, this one modifies onelens_backend_client_v2/models.py, adding new classes and updating existing ones, which aligns with the changes in the main PR.
  • updated python client with fixed feature service api call #35: This PR introduces new classes and modifies existing ones in onelens_backend_client_v2/models.py, which could be related to the extensive updates in the main PR regarding ticket activities and model structures.

Suggested reviewers

  • kaushikkishore
  • sidpan1

🐰 In the land of code where rabbits hop,
New classes and methods make our hearts stop!
Ticket activities, now tracked with glee,
With UUID4, we code so free!
So let’s celebrate this change so bright,
Hopping through models, what a delightful sight! 🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@pranjal-astuto pranjal-astuto merged commit 0c85efa into main Nov 20, 2024
1 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant