Sid/ask navira

[sidpan1]

Summary by CodeRabbit

• New Features

  • Introduced new classes for enhanced resource management and SQL generation, including Column, TableMetadata, and various request/response models.
  • Added functionality to disable metrics via a new method in the metrics control service.
  • Launched the NaviraResourceExplorerServiceRpcHandler for improved interaction with resource explorer services, supporting SQL execution and metadata retrieval.

• Bug Fixes

  • Adjusted default values for pagination parameters and added optional fields in various models to enhance usability.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request introduces multiple enhancements to the onelens_backend_client_v2 module, primarily focusing on the addition of new classes and methods in various files. Key additions include new request and response models in models.py, a new RPC handler in navira_resource_explorer_service_rpc_handler.py, and the implementation of a metric disabling feature in metrics_control_service_rpc_handler.py. The changes aim to improve functionality related to metrics, resource exploration, and SQL generation while maintaining the overall structure of the existing models.

Changes

File Path	Change Summary
onelens_backend_client_v2/models.py	Added multiple classes: Column, DisableMetricsResponse, ExampleQuery, GetServiceAndResourceTypeRequest, GetServiceAndResourceTypeResponse, ResourceCatalogExplorerRequest, ResourceCatalogExplorerResponse, TableType, TableMetadata, GenerateSQLRequest, GenerateSQLResponse, SelectTablesRequest, SelectTablesResponse. Minor adjustments to existing classes.
onelens_backend_client_v2/rpc/__init__.py	Added import for NaviraResourceExplorerServiceRpcHandler and updated __all__ list.
onelens_backend_client_v2/rpc/metrics_control_service_rpc_handler.py	Added disable_metric method and _disable_metric_serialize method to MetricsControlServiceRpcHandler.
onelens_backend_client_v2/rpc/navira_resource_explorer_service_rpc_handler.py	Introduced NaviraResourceExplorerServiceRpcHandler class with methods: execute_sql, generate_sql, get_resource_catalog_sql_query, get_service_and_resource_type, get_table_metadata, and select_tables.

Possibly related PRs

• added recreate hierarchy mappings #26: The changes in onelens_backend_client_v2/models.py involve the addition of new classes and fields, which may relate to the overall structure and functionality enhancements in the main PR that also adds multiple new classes and fields.
• Updated the python client model #30: This PR also modifies onelens_backend_client_v2/models.py by adding new classes and updating existing ones, similar to the main PR's focus on enhancing the data model with new request and response classes.
• Updated the python client #33: The introduction of new classes and modifications in onelens_backend_client_v2/models.py in this PR aligns with the main PR's changes that enhance the data model with new classes and fields.
• updated python client with fixed feature service api call #35: This PR adds new classes and modifies existing ones in onelens_backend_client_v2/models.py, which is consistent with the main PR's focus on expanding the API's capabilities through new model definitions.

Suggested reviewers

• kaushikkishore
• pranjal-astuto
• Shivam-yadav2de

🐇 In the code where data flows,
New classes and methods grow.
Metrics disabled, queries made,
A resource explorer's grand parade!
With each line, our models thrive,
In this code, we come alive! 🌟

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.