Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Minor fix)eJWST - remove login_gui method from documentation #2257

Merged
merged 3 commits into from
Jan 11, 2022
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
login_gui removed from JWST
  • Loading branch information
jespinosaar committed Jan 10, 2022
commit 6788573c854476e7d52548b4b052ee19a2795863
11 changes: 0 additions & 11 deletions astroquery/esa/jwst/core.py
Original file line number Diff line number Diff line change
@@ -647,17 +647,6 @@ def login(self, *, user=None, password=None, credentials_file=None,
if token:
self.set_token(token=token)

def login_gui(self, *, verbose=False):
"""Performs a login using a GUI dialog
TAP+ only

Parameters
----------
verbose : bool, optional, default 'False'
flag to display information about the process
"""
return self.__jwsttap.login_gui(verbose)

def logout(self, *, verbose=False):
"""Performs a logout
TAP+ only
3 changes: 2 additions & 1 deletion astroquery/esa/jwst/data_access.py
Original file line number Diff line number Diff line change
@@ -10,14 +10,15 @@
"""

from astropy.utils import data
from . import conf

__all__ = ['JwstDataHandler']


class JwstDataHandler:
def __init__(self, base_url=None):
if base_url is None:
self.base_url = "http://jwstdummydata.com"
self.base_url = conf.JWST_DATA_SERVER
else:
self.base_url = base_url

8 changes: 0 additions & 8 deletions astroquery/esa/jwst/tests/test_jwsttap.py
Original file line number Diff line number Diff line change
@@ -1002,14 +1002,6 @@ def test_login(self):
tap.login(user='test_user', password='test_password')
dummyTapHandler.check_call('login', parameters)

def test_login_gui(self):
dummyTapHandler = DummyTapHandler()
tap = JwstClass(tap_plus_handler=dummyTapHandler, show_messages=False)
parameters = {}
parameters['verbose'] = False
tap.login_gui()
dummyTapHandler.check_call('login_gui', parameters)

def test_logout(self):
dummyTapHandler = DummyTapHandler()
tap = JwstClass(tap_plus_handler=dummyTapHandler, show_messages=False)