Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Minor fix)eJWST - remove login_gui method from documentation #2257

Merged
merged 3 commits into from
Jan 11, 2022

Conversation

jespinosaar
Copy link
Contributor

Hi @bsipocz,

I have just realized an error in the documentation, as the login_gui method is not included and should be removed. This pull request aims to fix this.

Thanks in advance!

@jespinosaar
Copy link
Contributor Author

Let's see how we can deal with the errors in the tests...

Copy link
Member

@bsipocz bsipocz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for changelog entry, otherwise this looks all good to me. I go ahead and merge this not, but will remove the changelog separately, release time at the latest.

@bsipocz
Copy link
Member

bsipocz commented Jan 11, 2022

Thanks, @jespinosaar! CI failure is unrelated and is dealt with separately.

@bsipocz bsipocz merged commit a31ab86 into astropy:main Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants