Alfalfa documentation clean up #1941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tinuademargaret
changed the title
bsipocz
force-pushed
the
alfalfa-doc-cleanup
branch
from
3777c30 to
8f330cf
Compare
|
@keflavich - please do a review if you're OK with getting rid of the iterator approach to work around the byte/str issues. |
Codecov Report
@@ Coverage Diff @@
## main #1941 +/- ##
=======================================
Coverage 62.96% 62.96%
=======================================
Files 133 133
Lines 17287 17287
=======================================
Hits 10885 10885
Misses 6402 6402
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
keflavich
approved these changes
May 16, 2022
|
@keflavich - did they get back to you? |
|
No, no reply. I think we need to add a deprecation tag to this whole module - it looks like the server that hosted the data is down and no mirror has been made. I guess we can merge this PR but open a new issue that this module connects to a remote service that is presently unavailable. I'd like the formal confirmation that it's never coming back before we delete the module, though. |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason querying spectrum
Alfalfa.get_spectrum(agc)times out. I'm yet to figure out why so I just commented out that part of the doc for now.