Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit modules and deprecated the unsupported ones #2417

Open
2 of 6 tasks
bsipocz opened this issue May 23, 2022 · 4 comments
Open
2 of 6 tasks

Audit modules and deprecated the unsupported ones #2417

bsipocz opened this issue May 23, 2022 · 4 comments
Labels
Milestone

Comments

@bsipocz
Copy link
Member

bsipocz commented May 23, 2022

Issues came up for alfalfa recently, and I recall that retiring/deprecating/removing came up for a few other ones, too. So this is a tracking issue as a reminder that we should go through all and decide. IMO it's better to raise a warning or even remove a module than drag a broken service around.

I milestone this to 0.4.7 as these should ideally be done before that release is tagged.

  • alfalfa
  • vamdc
  • some or the irsa services after their merger is done
  • noirlab
  • [ ] oac (see message on https://sne.space/)

When other preferences exist, deprecate and remove:

  • utils.tap in favour of pyvo TAP, this can only be done once the ESA modules are migrated
  • vo_conesearch in favour of pyvo
@bsipocz
Copy link
Member Author

bsipocz commented Sep 20, 2023

@keflavich - any vision for vamdc for 0.4.7? And what to do with oac?

As for IRSA, the sha rework/removal is due for 0.4.7, but I don't think the rest will be fall into that milestone.

@keflavich
Copy link
Contributor

no, vamdc isn't a priority right now.

For OAC: I guess we remove it? It doesn't do anything any more, right?

@bsipocz
Copy link
Member Author

bsipocz commented Sep 20, 2023

For OAC: I guess we remove it? It doesn't do anything any more, right?

It does, but as far as I understand (based on the link above) it's not being updated. Maybe a deprecation like we have for exoplanet_orbit_database?

@bsipocz bsipocz modified the milestones: v0.4.7, v0.4.8 Mar 9, 2024
@bsipocz
Copy link
Member Author

bsipocz commented Jan 3, 2025

Dace and SHA have been now removed. OAC is still operational, so I leave that alone. As for VAMDC, we should figure out a way fwd with that but I bumped that into the new release.
The old ipac namespaces are still in there, but can be also removed in the next release.

As for vo_conesearch - that will need a champion, as we mostly need some extra documentation into pyvo to show how to do the same things with existing tools, and the tapplus-->pyvo move is still on the table, but is not imminent.

So, with all that said, I remove the milestone here, but we may need to open individual issues rather than a big tracker like this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants