Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge development branch #452

Merged
merged 42 commits into from
Oct 22, 2024
Merged

Merge development branch #452

merged 42 commits into from
Oct 22, 2024

Conversation

camposandro
Copy link
Collaborator

Merges the changes performed on development during the HATS renaming back to the main branch.

dependabot bot and others added 30 commits October 1, 2024 20:23
@dependabot
Bump pre-commit-ci/lite-action from 1.0.2 to 1.0.3
b941d3b 
Bumps [pre-commit-ci/lite-action](https://github.com/pre-commit-ci/lite-action) from 1.0.2 to 1.0.3.
- [Release notes](https://github.com/pre-commit-ci/lite-action/releases)
- [Commits](pre-commit-ci/lite-action@v1.0.2...v1.0.3)

---
updated-dependencies:
- dependency-name: pre-commit-ci/lite-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@camposandro
Update number of positional args
3a69679
@camposandro
Run CI on development branch
7798376
@smcguire-cmu
update hipscat target
5054ddb
@smcguire-cmu
Merge pull request #426 from astronomy-commons/dependabot/github_acti…
0e38536 
…ons/pre-commit-ci/lite-action-1.0.3

Bump pre-commit-ci/lite-action from 1.0.2 to 1.0.3
@dougbrn
WIP: sketching out from_lists
e384736
@camposandro
Override catalog's __len__ method (#429)
76e2af4 
* Wrap catalog's length method

* Invalidate number of rows for all catalog operations

* Clarify error message
@dougbrn
change to nest_lists
2554f1d
@dougbrn
change to nest_lists
ef1940d
@dougbrn
implement at healpix_dataset level
9bac17f
@dougbrn
WIP: sketching out from_lists
8875ac5
@dougbrn
change to nest_lists
59c294c
@dougbrn
change to nest_lists
ec092bc
@dougbrn
implement at healpix_dataset level
11548ea
@dougbrn
keep current
07d65b0
@dougbrn
main test written
1a58311
@smcguire-cmu
wrap reduce healpix_dataset.py
642c268
@smcguire-cmu
wrap in catalog
b45d7db
@smcguire-cmu
update signature to match
fdfdfad
@smcguire-cmu
unit test
bc32520
@smcguire-cmu
isort
04f82e4
@smcguire-cmu
wip
549f729
@smcguire-cmu
add reduce append_columns
d842ece
@smcguire-cmu
add append_columns test
714bee3
@smcguire-cmu
add docstring
d75758e
@smcguire-cmu
add unit test
1d9fc7f
@smcguire-cmu
pr
783ed13
@smcguire-cmu
isort
b613df7
@smcguire-cmu
Merge pull request #414 from astronomy-commons/sean/reduce
be78673 
Wrap nested_dask `reduce`
@dougbrn
main test
68eb665
@codecov Codecov
Copy link

codecov bot commented Oct 22, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 96.49123% with 2 lines in your changes missing coverage. Please review.

Project coverage is 97.76%. Comparing base (1a2ba00) to head (c4b6e8a).
Report is 78 commits behind head on main.

Files with missing lines Patch % Lines
src/lsdb/catalog/catalog.py 87.50% 2 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #452   +/-   ##
=======================================
  Coverage   97.75%   97.76%           
=======================================
  Files          44       44           
  Lines        1562     1609   +47     
=======================================
+ Hits         1527     1573   +46     
- Misses         35       36    +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 22, 2024 •
edited
Loading

Before [1a2ba00] After [b1bd419] Ratio Benchmark (Parameter)
failed failed n/a benchmarks.time_box_filter_on_partition
failed failed n/a benchmarks.time_create_large_catalog
failed failed n/a benchmarks.time_create_midsize_catalog
30.8±0.4ms 30.6±0.5ms 1.00 benchmarks.time_polygon_search
97.7±0.9ms 96.7±0.8ms 0.99 benchmarks.time_kdtree_crossmatch

Click here to view all benchmarks.

@camposandro camposandro merged commit 9b1e15b into main Oct 22, 2024
9 of 12 checks passed
@camposandro camposandro deleted the development branch October 22, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delucchi-cmu delucchi-cmu delucchi-cmu approved these changes

@smcguire-cmu smcguire-cmu Awaiting requested review from smcguire-cmu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@camposandro @delucchi-cmu @smcguire-cmu @dougbrn