Override catalog's __len__ method
#429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Click here to view all benchmarks. |
camposandro
force-pushed
the
issue/404/catalog-len-method
branch
from
0ba68b1 to
6ca27bb
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## development #429 +/- ##
===============================================
+ Coverage 97.87% 97.94% +0.07%
===============================================
Files 44 44
Lines 1553 1560 +7
===============================================
+ Hits 1520 1528 +8
+ Misses 33 32 -1 ☔ View full report in Codecov by Sentry. |
smcguire-cmu
approved these changes
Oct 8, 2024
camposandro
added a commit
that referenced
this pull request
Oct 22, 2024
* Bump pre-commit-ci/lite-action from 1.0.2 to 1.0.3 Bumps [pre-commit-ci/lite-action](https://github.com/pre-commit-ci/lite-action) from 1.0.2 to 1.0.3. - [Release notes](https://github.com/pre-commit-ci/lite-action/releases) - [Commits](pre-commit-ci/lite-action@v1.0.2...v1.0.3) --- updated-dependencies: - dependency-name: pre-commit-ci/lite-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Update number of positional args * Run CI on development branch * update hipscat target * WIP: sketching out from_lists * Override catalog's `__len__` method (#429) * Wrap catalog's length method * Invalidate number of rows for all catalog operations * Clarify error message * change to nest_lists * change to nest_lists * implement at healpix_dataset level * WIP: sketching out from_lists * change to nest_lists * change to nest_lists * implement at healpix_dataset level * main test written * wrap reduce healpix_dataset.py * wrap in catalog * update signature to match * unit test * isort * wip * add reduce append_columns * add append_columns test * add docstring * add unit test * pr * isort * main test * lint fix * test compute * Explode kwargs for ra and dec in from_dataframe (#437) * use alignment moc in crossmatched/joined catalogs * remove unused import * update docs hipscat branch * Fix unit test --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Sean McGuire <seanmcgu@andrew.cmu.edu> Co-authored-by: Sean McGuire <123987820+smcguire-cmu@users.noreply.github.com> Co-authored-by: Doug Branton <brantd@uw.edu> Co-authored-by: Doug Branton <dougrbranton@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Override the built-in
__len__method to provide the number of rows for unmodified catalogs. I also added docstrings onqueryanddropnafor better clarity (they existed in the base class but not inCatalog). Closes #404.