Add error message for validate connections #1554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feluelle
requested review from
dimberman,
tatiana,
pankajastro and
pankajkoti
as code owners
Codecov ReportBase: 94.01% // Head: 97.71% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1554 +/- ##
==========================================
+ Coverage 94.01% 97.71% +3.69%
==========================================
Files 89 22 -67
Lines 4347 787 -3560
Branches 428 0 -428
==========================================
- Hits 4087 769 -3318
+ Misses 178 18 -160
+ Partials 82 0 -82 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
pankajkoti
approved these changes
Jan 10, 2023
tatiana
reviewed
Jan 10, 2023
tatiana
approved these changes
Jan 10, 2023
Co-authored-by: Tatiana Al-Chueyr <tatiana.alchueyr@gmail.com>
for more information, see https://pre-commit.ci
feluelle
commented
Jan 10, 2023
utkarsharma2
pushed a commit
that referenced
this pull request
Jan 17, 2023
# Description ## What is the current behavior? Currently, we are not giving any hints to the user about an invalid/failed connection. closes: #1535 ## What is the new behavior? Print an error message when validating a connection. ## Does this introduce a breaking change? Yes, kind of. We are not erroring out anymore when the file path internally could not get resolved in case of sqlite connections. This is so that an invalid sqlite connection does not block you from running any generate/validate/run commands. Previously it was raising an exception which led to an immediate exit. ### Checklist - [x] Created tests which fail without the change (if possible) - [ ] Extended the README / documentation, if necessary Co-authored-by: Tatiana Al-Chueyr <tatiana.alchueyr@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is the current behavior?
Currently, we are not giving any hints to the user about an invalid/failed connection.
closes: #1535
What is the new behavior?
Print an error message when validating a connection.
Does this introduce a breaking change?
Yes, kind of. We are not erroring out anymore when the file path internally could not get resolved in case of sqlite connections. This is so that an invalid sqlite connection does not block you from running any generate/validate/run commands. Previously it was raising an exception which led to an immediate exit.
Checklist