Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print error message in validate command #1535

Closed
feluelle opened this issue Jan 5, 2023 · 0 comments · Fixed by #1554
Closed

Print error message in validate command #1535

feluelle opened this issue Jan 5, 2023 · 0 comments · Fixed by #1554
Assignees
@feluelle
Labels
product/sql-cli
Milestone
sql-cli/0.3.0

Comments

@feluelle
Copy link
Member

feluelle commented Jan 5, 2023

As mentioned in #1177 (comment), the "validate" command should output error messages. So that as a user I know what I can do to fix an invalid connection.
@feluelle feluelle self-assigned this Jan 9, 2023
@feluelle feluelle mentioned this issue Jan 9, 2023
Merged
2 tasks
@feluelle feluelle added this to the sql-cli/0.3.0 milestone Jan 9, 2023
utkarsharma2 pushed a commit that referenced this issue Jan 17, 2023
@feluelle @tatiana
@pre-commit-ci @utkarsharma2
Add error message for validate connections (#1554)
34877aa 
# Description

## What is the current behavior?

Currently, we are not giving any hints to the user about an
invalid/failed connection.

closes: #1535

## What is the new behavior?

Print an error message when validating a connection.

## Does this introduce a breaking change?

Yes, kind of. We are not erroring out anymore when the file path
internally could not get resolved in case of sqlite connections. This is
so that an invalid sqlite connection does not block you from running any
generate/validate/run commands. Previously it was raising an exception
which led to an immediate exit.

### Checklist
- [x] Created tests which fail without the change (if possible)
- [ ] Extended the README / documentation, if necessary

Co-authored-by: Tatiana Al-Chueyr <tatiana.alchueyr@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@feluelle feluelle

Labels
product/sql-cli
Projects
None yet
Milestone
sql-cli/0.3.0
Development

Successfully merging a pull request may close this issue.

Add error message for validate connections astronomer/astro-sdk
1 participant
@feluelle