Flow project.json info into assembly info. #2950
Conversation
|
Hi @CesarBS, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! The agreement was validated by .NET Foundation and real humans are currently evaluating your PR. TTYL, DNFBOT; |
| @@ -1,7 +1,7 @@ | |||
| DNX | |||
| === | |||
|
|
|||
| Travis: [](https://travis-ci.org/aspnet/dnx) | |||
| Travis: [](https://travis-ci.org/aspnet/dnx) | |||
There was a problem hiding this comment.
Why do you update the branch?
There was a problem hiding this comment.
To see the thingy going green in the repo page :)
There was a problem hiding this comment.
That's pretty weird 😄 You can just check travis itself.
|
No tests? (sad panda) |
| { | ||
| string attributeName = assembly.AttributeClass.ToString(); | ||
| string attributeName = attribute.AttributeClass.ToString(); |
There was a problem hiding this comment.
nit: use var instead of string
|
Add a test that verifies the assembly information is written after building. It should be part of the DnuPackTests |
* On windows value returned by GetVersionEx * On unix.coreclr and mono targets we now search for ID, VERSION_ID keys in /etc/os-release
- pick up latest `build.cmd` and `build.sh` files - use `DnxTest()` macro rather than local `KTest()` function - `KTest()` broke due to `K()` -> `Dnx()` rename nits: - remove trailing whitespace in `makefile.shade` - restore `--quiet`'s operation on `dnu restore` - lost in commit 015e8a5
…/dnx into cesarbs/dnx-assembly-info
| @@ -4,8 +4,8 @@ cd %~dp0 | |||
| SETLOCAL | |||
There was a problem hiding this comment.
I have no idea what happened here.
|
Not flowing "language" from project.json as AssemblyCulture into the assembly since it looks like that has already been handled by #2802. |
|
I will close this pr and open a new one, since this one got messed up with unrelated changes. |
#2715