This repository has been archived by the owner on Dec 18, 2017. It is now read-only.
fix #1683 by preferring listed packages #2156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -24,6 +24,10 @@ public class NuGetv2Feed : IPackageFeed | |||
| private static readonly XName _xnameProperties = XName.Get("properties", "http://schemas.microsoft.com/ado/2007/08/dataservices/metadata"); | |||
| private static readonly XName _xnameId = XName.Get("Id", "http://schemas.microsoft.com/ado/2007/08/dataservices"); | |||
| private static readonly XName _xnameVersion = XName.Get("Version", "http://schemas.microsoft.com/ado/2007/08/dataservices"); | |||
| private static readonly XName _xnamePublish = XName.Get("Published", "http://schemas.microsoft.com/ado/2007/08/dataservices"); | |||
There was a problem hiding this comment.
Extract the string of namespace to a constant value?
There was a problem hiding this comment.
Even better - you can just use + instead of XName.Get().
There was a problem hiding this comment.
create:
XNamespace astoriaNs = "http://schemas.microsoft.com/ado/2007/08/dataservices");
use inline:
... astoriaNs + "Published" ...
|
⌚ |
analogrelay
force-pushed
the
anurse/1683-prefer-unlisted
branch
from
63e09c2
to
407c4e5
Compare
| private static readonly XName _xnameProperties = XName.Get("properties", "http://schemas.microsoft.com/ado/2007/08/dataservices/metadata"); | ||
| private static readonly XName _xnameId = XName.Get("Id", "http://schemas.microsoft.com/ado/2007/08/dataservices"); | ||
| private static readonly XName _xnameVersion = XName.Get("Version", "http://schemas.microsoft.com/ado/2007/08/dataservices"); | ||
| private static readonly XNamespace _odataMetadataNamespace = XNamespace.Get("http://schemas.microsoft.com/ado/2007/08/dataservices/metadata"); |
There was a problem hiding this comment.
nit: you don't need XNamespace.Get - just
private static readonly XNamespace _odataMetadataNamespace = "http://schemas.microsoft.com/ado/2007/08/dataservices/metadata";
it will know to convert the string to XNamespace
There was a problem hiding this comment.
I suppose... though I dislike implicit conversion operators :). I'll do it though, because you asked nicely :P
analogrelay
force-pushed
the
anurse/1683-prefer-unlisted
branch
from
407c4e5
to
8222546
Compare
|
|
...but accepting unlisted packages if there are no matches
analogrelay
force-pushed
the
anurse/1683-prefer-unlisted
branch
from
8222546
to
8fd7e41
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...but accepting unlisted packages if there are no matches
Fixes #1683
/cc @davidfowl @ChengTian