Skip to content
This repository has been archived by the owner on Dec 18, 2017. It is now read-only.

DNU restore should still restore unlisted packages #1683

Closed
danroth27 opened this issue Apr 21, 2015 · 6 comments
Closed

DNU restore should still restore unlisted packages #1683

danroth27 opened this issue Apr 21, 2015 · 6 comments
Assignees
Milestone

Comments

@danroth27
Copy link
Member

If the Published date value is 1900-01-01T00:00:00 , then the package is unlisted and it should no longer be considered in dependency resolution when versions are being selected, or during initial installs of packages where users are discovering versions.

However, these "unlisted" versions must still be allowed when the user is restoring packages so that the version doesn't disappear out from under them and break their build.

This feature allows package authors to unlist packages for two reasons:
1.The package is being staged for an upcoming release announcement and they want to list the package at the time of the announcement.
2.The package has a very bad bug and the author doesn't want any new users to discover the version that has the bug.

The logic may be different for the v3 feed and we will need to account for that when we add support for v3.

@davidfowl
Copy link
Member

What? #1208

@danroth27
Copy link
Member Author

Yes, did you read Jeff's comment in #1208?

@muratg
Copy link
Contributor

muratg commented Apr 23, 2015

@davidfowl we need to close on the decision here, and perhaps implement it as part of the ongoing nuget work.

@davidfowl
Copy link
Member

I'm reverting the whole change. We dont have a difference between restore and install. Thats a much bigger discussion. We can potentially warn on restore of an unlisted package.

davidfowl added a commit that referenced this issue May 6, 2015
@davidfowl davidfowl reopened this May 28, 2015
@davidfowl davidfowl modified the milestones: 1.0.0-beta6, 1.0.0-beta5 May 28, 2015
@davidfowl davidfowl removed their assignment May 28, 2015
@davidfowl
Copy link
Member

@muratg reopening this and moving it to beta6. We need to prefer listed and if that results in no matches, then use unlisted.

@muratg
Copy link
Contributor

muratg commented Jun 24, 2015

@anurse One of the important ones we should fix.

analogrelay added a commit that referenced this issue Jun 29, 2015
...but accepting unlisted packages if there are no matches
analogrelay added a commit that referenced this issue Jun 30, 2015
...but accepting unlisted packages if there are no matches
analogrelay added a commit that referenced this issue Jul 1, 2015
...but accepting unlisted packages if there are no matches
analogrelay added a commit that referenced this issue Jul 1, 2015
...but accepting unlisted packages if there are no matches
analogrelay added a commit that referenced this issue Jul 1, 2015
...but accepting unlisted packages if there are no matches
analogrelay added a commit that referenced this issue Jul 1, 2015
analogrelay added a commit that referenced this issue Jul 1, 2015
...but accepting unlisted packages if there are no matches
analogrelay added a commit that referenced this issue Jul 2, 2015
...but accepting unlisted packages if there are no matches
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants