Skip to content
This repository has been archived by the owner on Dec 14, 2018. It is now read-only.

[WIP] add source link support to portable pdbs #5860

Closed
wants to merge 14 commits into from

Commits on Feb 26, 2017

  1. Convert MVC to CSproj.

    - Allow >= RC3 CLI's to build and run MVC.
    - Added extra sln's so they could be opened in VS. Currently VS' project system can't currently handle Mvc.sln.
    - Worked around several dotnet migration issues. They are listed in the re-attempted migration section here: aspnet#5482
    - One large feature bit that couldn't be worked around was the functional tests running on desktop; it represented several known vstest issues. Removed desktop running of functional tests.
    - Skipped an ActionContextAccessor test due to a vstest appdomain problem.
    NTaylorMullen authored and dougbu committed Feb 26, 2017
    Configuration menu
    Copy the full SHA
    dbc00e0 View commit details
    Browse the repository at this point in the history
  2. Addressed code review comments.

    NTaylorMullen authored and dougbu committed Feb 26, 2017
    Configuration menu
    Copy the full SHA
    de7b4d0 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c808c90 View commit details
    Browse the repository at this point in the history
  4. Addressed code review comments.

    NTaylorMullen authored and dougbu committed Feb 26, 2017
    Configuration menu
    Copy the full SHA
    e43b537 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    c5e090b View commit details
    Browse the repository at this point in the history
  6. Apply test migration to .NET 4.5.2 in *.csproj world

    - see 63507c8 for previous, project.json work
    - xUnit no longer supports .NET 4.5.1
    - build tests for desktop .NET only on Windows
    - always place xunit.runner.visualstudio dependency after xunit; helps build scripts run correctly
    dougbu committed Feb 26, 2017
    Configuration menu
    Copy the full SHA
    daac4be View commit details
    Browse the repository at this point in the history
  7. Apply dependency version downgrade from 0097e40 in .csproj world

    Question: Should Microsoft.Extensions.DependencyModel dependency really be 1.1.0?
    dougbu committed Feb 26, 2017
    Configuration menu
    Copy the full SHA
    a51f2ee View commit details
    Browse the repository at this point in the history
  8. Update MSBuild migration files and remove some unnecessary difference…

    …s from dev
    
    - manually recreate *.sln files to correct VS versions and use old project GUIDs
      - add missing lines to the .sln files; build configuration likely not used before
    - manually migrate RazorPagesWebSite project
    - remove `ToolsVersion` attributes
    - add repo.props file; never test TestCommon project and only build Mvc.sln
    - add dependencies.props file to match other repos
    
    Test-related:
    - add `$(PreserveCompilationContext)` to test projects that examine their own dependencies
    - remove comments from xunit.runner.json files; xUnit does not support them
    - remove .notest files
    - work around inability to deserialize a odd `ref` type
      - xUnit and vstest now serialize / deserialze test data more often
    - work around microsoft/vstest#419 instead of skipping test
    - enable testes that hit microsoft/vstest#427; bug has been fixed
    - add `<Service>`s to test projects
    dougbu committed Feb 26, 2017
    Configuration menu
    Copy the full SHA
    5a197bd View commit details
    Browse the repository at this point in the history
  9. Move TestDiagnosticListener.Sources back into test folder

    - build unconditionally creates a package if this is in the shared folder
    - basically, remove the .xproj that's in old world and compile the files in
    dougbu committed Feb 26, 2017
    Configuration menu
    Copy the full SHA
    36ba0e5 View commit details
    Browse the repository at this point in the history
  10. PR comments

    - re-enable .NET Framework run of the functional tests
      - disable shadow copying
    - add support for `/p:GenerateBaselines=true` for functional and Razor.Host tests
    - remove aspnet/KoreBuild#182 workaround; bug fixed
    - remove `Microsoft.DotNet.InternalAbstractions` and `System.Xml.XmlDocument` dependencies
    - stop floating `$(CoreFxVersion)` and `Microsoft.Extensions.DependencyModel` dependencies
    - separate `GetCSharpTypeName_ReturnsCorrectTypeNames_ForOutParameter()` test
    - remove `$(RuntimeIdentifier)` settings
    
    nits:
    - remove all web.config files
    - remove conditional compilation from class libraries
    - remove unnecessary project properties from `UserClassLibrary`
    - move a few properties to the top of a .csproj file
    - remove some trailing whitespace in .csproj files
    dougbu committed Feb 26, 2017
    Configuration menu
    Copy the full SHA
    7d3f9ae View commit details
    Browse the repository at this point in the history
  11. Per offline conversation, make Microsoft.AspNetCore.Mvc.TestDiagnosti…

    …cListener a regular class library
    dougbu committed Feb 26, 2017
    Configuration menu
    Copy the full SHA
    d350769 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    f3ba66e View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2017

  1. PrivateAssets="all"

    ctaggart committed Feb 27, 2017
    Configuration menu
    Copy the full SHA
    d9c45c8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    189587d View commit details
    Browse the repository at this point in the history