This repository has been archived by the owner on May 21, 2019. It is now read-only.
DefaultItems.targets should calculate @(Solutions) consistently with other $(RepositoryRoot) uses
#182
Comments
dougbu
added a commit
to aspnet/Mvc
that referenced
this issue
Feb 26, 2017
- re-enable .NET Framework run of the functional tests - disable shadow copying - add support for `/p:GenerateBaselines=true` for functional and Razor.Host tests - remove aspnet/KoreBuild#182 workaround; bug fixed - separate `GetCSharpTypeName_ReturnsCorrectTypeNames_ForOutParameter()` test - remove `Microsoft.DotNet.InternalAbstractions` and `System.Xml.XmlDocument` dependencies - stop floating `$(CoreFxVersion)` and Microsoft.Extensions.DependencyModel dependencies - remove `$(RuntimeIdentifier)` settings - move a few property settings to the top of a .csproj - remove all web.config files nit: remove some trailing whitespace in .csproj files
dougbu
added a commit
to aspnet/Mvc
that referenced
this issue
Feb 26, 2017
- re-enable .NET Framework run of the functional tests - disable shadow copying - add support for `/p:GenerateBaselines=true` for functional and Razor.Host tests - remove aspnet/KoreBuild#182 workaround; bug fixed - remove `Microsoft.DotNet.InternalAbstractions` and `System.Xml.XmlDocument` dependencies - stop floating `$(CoreFxVersion)` and `Microsoft.Extensions.DependencyModel` dependencies - separate `GetCSharpTypeName_ReturnsCorrectTypeNames_ForOutParameter()` test - remove `$(RuntimeIdentifier)` settings nits: - remove all web.config files - remove conditional compilation from class libraries - remove unnecessary project properties from `UserClassLibrary` - move a few properties to the top of a .csproj file - remove some trailing whitespace in .csproj files
dougbu
added a commit
to aspnet/Mvc
that referenced
this issue
Feb 26, 2017
- re-enable .NET Framework run of the functional tests - disable shadow copying - add support for `/p:GenerateBaselines=true` for functional and Razor.Host tests - remove aspnet/KoreBuild#182 workaround; bug fixed - remove `Microsoft.DotNet.InternalAbstractions` and `System.Xml.XmlDocument` dependencies - stop floating `$(CoreFxVersion)` and `Microsoft.Extensions.DependencyModel` dependencies - separate `GetCSharpTypeName_ReturnsCorrectTypeNames_ForOutParameter()` test - remove `$(RuntimeIdentifier)` settings nits: - remove all web.config files - remove conditional compilation from class libraries - remove unnecessary project properties from `UserClassLibrary` - move a few properties to the top of a .csproj file - remove some trailing whitespace in .csproj files
dougbu
added a commit
to aspnet/Mvc
that referenced
this issue
Feb 27, 2017
…s from dev - manually recreate *.sln files to correct VS versions and use old project GUIDs - add missing lines to the .sln files; build configuration likely not used before - manually migrate RazorPagesWebSite project - remove `ToolsVersion` attributes - add repo.props file; never test TestCommon project and only build Mvc.sln - remove aspnet/KoreBuild#182 workaround; bug fixed - remove `Microsoft.DotNet.InternalAbstractions` and `System.Xml.XmlDocument` dependencies - stop floating `$(CoreFxVersion)` and `Microsoft.Extensions.DependencyModel` dependencies - add dependencies.props file to match other repos Test-related: - re-enable .NET Framework run of the functional tests - disable shadow copying - make Microsoft.AspNetCore.Mvc.TestDiagnosticListener a regular class library - add support for `/p:GenerateBaselines=true` for functional and Razor.Host tests - add `$(PreserveCompilationContext)` to test projects that examine their own dependencies - remove `$(RuntimeIdentifier)` settings - remove comments from xunit.runner.json files; xUnit does not support them - remove .notest files - separate `GetCSharpTypeName_ReturnsCorrectTypeNames_ForOutParameter()` test - work around inability to deserialize a odd `ref` type - xUnit and vstest now serialize / deserialze test data more often - work around microsoft/vstest#419 instead of skipping test - enable tests that hit microsoft/vstest#427; bug has been fixed - add `<Service>`s to test projects nits: - remove all web.config files - remove conditional compilation from class libraries - remove unnecessary project properties from `UserClassLibrary` - move a few properties to the top of `RazorWebSite` .csproj file - remove some trailing whitespace in .csproj files
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
$(RepositoryRoot)always ends with a slash and code removing members of item groups must match existing members' text. .props and .targets files in this repo should therefore use properties consistently when creating item groups. Unfortunately line 8 in DefaultItems.targets does not follow this recommendation.Remove the slash after
$(Repository)root, allowing@(ExcludeSolutions)to work as expected.The text was updated successfully, but these errors were encountered: