This repository has been archived by the owner on Dec 18, 2018. It is now read-only.
Reduce closure allocation #287
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Still 15 closures capturing via heap vs 28 previously; but number of variables in remaining ones is reduced. Also most allocating delegates changed to non-allocating lamda expressions. |
|
2002 requests before 2004 requests after |
|
Needs to go further; some of the closures remaining are too heavy... |
|
Next iteration for 2005 requests Need to clean up names before I add commit |
| @@ -27,7 +28,7 @@ public class Program | |||
|
|
|||
| public int Main() | |||
| { | |||
| return new Xunit.Runner.Dnx.Program(env, sp, _libraryManager).Main(new string[] | |||
| return new Xunit.Runner.Dnx.Program(env, sp, _libraryManager, _shutdown).Main(new string[] | |||
This was referenced Oct 24, 2015
benaadams
force-pushed
the
remove-closures
branch
from
75211c5
to
f48276f
Compare
|
No sure about this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes a couple closure allocations identified in #286