This repository has been archived by the owner on Nov 20, 2018. It is now read-only.
Allow DefaultHttpContext to be pooled [Design] #404
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @benaadams, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! The agreement was validated by .NET Foundation and real humans are currently evaluating your PR. TTYL, DNFBOT; |
| @@ -168,8 +185,26 @@ public override void Abort() | |||
|
|
|||
| public override void Dispose() | |||
| { | |||
| // REVIEW: is this necessary? is the environment "owned" by the context? | |||
There was a problem hiding this comment.
Question has moved to -> https://github.com/aspnet/HttpAbstractions/pull/404/files#diff-ad404d59bc5860d71b7403b8e0a665b2R102
| @@ -109,5 +114,13 @@ public override IEnumerable<AuthenticationDescription> GetAuthenticationSchemes( | |||
| throw new InvalidOperationException($"The following authentication scheme was not accepted: {authenticationScheme}"); | |||
| } | |||
| } | |||
|
|
|||
| public void Dispose() | |||
|
See #402 (comment) for details on server run improvements (61.5k rps -> 1.49M rps) |
| @@ -116,5 +121,14 @@ public override void Redirect(string location, bool permanent) | |||
|
|
|||
| Headers[HeaderNames.Location] = location; | |||
| } | |||
|
|
|||
| public void Dispose() | |||
| { | |||
benaadams
changed the title
|
Closing this as discussed with @benaadams |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Half of #402 needs change to Hosting also