Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/modernize cmake #3

Merged
merged 2 commits into from
May 12, 2021
Merged

Feature/modernize cmake #3

merged 2 commits into from
May 12, 2021

Conversation

haudren
Copy link

@haudren haudren commented May 12, 2021

This PR does a little bit of cleanup in the CMake file:

  • Use more targets
  • Use less explicit flags
  • Don't look for useless targets (notably OpenGL is found and dlopen'd at runtime)
  • Add PCL as a dependency in the cmake config file

The last point fixes errors with finding vtk libraries

@haudren
Use more targets, don't find OpenGL
bdf163c 
Indeed, we are runtime-finding OpenGL so no need to look for it in
CMake. As we are only targeting Ubuntu 18.04 and up, let's use targets
for Threads and Eigen
@haudren
Add PCL dependency to config.cmake
e7c5f8b
@haudren haudren merged commit ca1b59e into master May 12, 2021
@haudren haudren deleted the feature/modernize-cmake branch May 12, 2021 07:43
@haudren haudren restored the feature/modernize-cmake branch May 12, 2021 07:43
@haudren haudren mentioned this pull request May 17, 2021
Open
ChamzasKonstantinos referenced this pull request in KavrakiLab/gl_depth_sim May 6, 2022
@haudren @ChamzasKonstantinos
Merge pull request #3 from ascentai/feature/modernize-cmake
6c73d61 
Feature/modernize cmake
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@haudren