Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add interactive method to distributions #145

Merged
merged 4 commits into from
Dec 17, 2022
Merged

add interactive method to distributions #145

merged 4 commits into from
Dec 17, 2022

Conversation

aloctavodia
Copy link
Contributor

@aloctavodia aloctavodia commented Dec 16, 2022

closes #144. This allows setting the parameters of distribution interactively using sliders.

Captura desde 2022-12-16 20-34-18

There are still some issues, but I left those for future PRs. For example, the user needs to define starting values, but it could be useful to offer some arbitrary values by default, especially for newbie users and/or not very common distributions. There is also a dirty heuristic to define the min, max, and step values of sliders, which could be better, etc.

@codecov-commenter
Copy link

codecov-commenter commented Dec 16, 2022

Codecov Report

Merging #145 (c23ab15) into main (d65ff34) will decrease coverage by 1.25%.
The diff coverage is 35.08%.

@@            Coverage Diff             @@
##             main     #145      +/-   ##
==========================================
- Coverage   78.71%   77.45%   -1.26%     
==========================================
  Files          18       18              
  Lines        2119     2165      +46     
==========================================
+ Hits         1668     1677       +9     
- Misses        451      488      +37     
Impacted Files Coverage Δ
preliz/distributions/distributions.py 63.33% <7.50%> (-20.31%) ⬇️
preliz/distributions/continuous.py 98.65% <100.00%> (+<0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add interactivity to distributions
2 participants