fix(playwright): ensure engine knows when tracing is enabled #2533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix for #2529
Before #2418, Playwright tracing only worked with OTeL, but now it can work with other reports that use OTeL behind the scenes.
We now check for a
OTEL_TRACING_ENABLEDvariable set by the otel reporter instead, which should be in control of whether tracing is needed (which also reduces the coupling between the PW engine and publish-metrics).Testing
Tested locally and with Fargate. Automated tests for this as not very easy (as it depends on platform integrations), so can be added separately.
Pre-merge checklist