fix(playwright): ensure engine knows when tracing is enabled (#2533)

artilleryio · Mar 4, 2024 · 018c917 · 018c917
1 parent 6b6ff07
commit 018c917
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/packages/artillery-engine-playwright/index.js b/packages/artillery-engine-playwright/index.js
@@ -11,8 +11,7 @@ class PlaywrightEngine {
     this.launchOptions = this.config.launchOptions || {};
     this.contextOptions = this.config.contextOptions || {};
 
-    this.tracing = (script.config?.plugins?.['publish-metrics'] || []).some((config) => {
-      return (config.type === 'open-telemetry') && config.traces})
+    this.tracing = global.artillery.OTEL_TRACING_ENABLED || false;
 
     this.defaultNavigationTimeout =
       (parseInt(this.config.defaultNavigationTimeout, 10) || 30) * 1000;

diff --git a/packages/artillery-plugin-publish-metrics/lib/open-telemetry/index.js b/packages/artillery-plugin-publish-metrics/lib/open-telemetry/index.js
@@ -68,7 +68,9 @@ class OTelReporter {
     if (!this.metricsConfig && !this.tracesConfig) {
       return this;
     }
-
+    if (this.tracesConfig) {
+      global.artillery.OTEL_TRACING_ENABLED = true;
+    }
     // Warn if traces are configured in multiple reporters
     this.warnIfDuplicateTracesConfigured(this.translatedConfigsList);