Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Glassfish6 container to a glassfish6 branch #12

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

starksm64
Copy link
Member

Short description of what this resolves:

Move the current GlassFish6 container into a glassfish6 branch

Changes proposed in this pull request:

Save the current GlassFish6 work
Incorporate #7
Update artifacts to remove GlassFish version as per #8

Fixes #
#8

Signed-off-by: Scott M Stark <starksm64@gmail.com>
Signed-off-by: Scott M Stark <starksm64@gmail.com>
Signed-off-by: Scott M Stark <starksm64@gmail.com>
Signed-off-by: Scott M Stark <starksm64@gmail.com>
…as artifiact

Signed-off-by: Scott M Stark <starksm64@gmail.com>
Signed-off-by: Scott M Stark <starksm64@gmail.com>
Signed-off-by: Scott M Stark <starksm64@gmail.com>
Signed-off-by: Scott M Stark <starksm64@gmail.com>
Signed-off-by: Scott M Stark <starksm64@gmail.com>
Signed-off-by: Scott M Stark <starksm64@gmail.com>
glassfish-common/pom.xml Outdated Show resolved Hide resolved
@bartoszmajsak
Copy link
Member

bartoszmajsak commented Apr 12, 2022

@starksm64 I am not sure why this repo is under jakartaredhat in Circle-CI. Any ideas?

It seems the build failure is related to it - it cannot clone the repo with this org assigned.

Can you try to push a commit - I changed the config.

Copy link
Member

@bartoszmajsak bartoszmajsak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this improvement @starksm64. I have just a few questions.

And one little ask in addition - can README.txt be converted to markdown, or better yet, asciidoc? :)

.circleci/config.yml Outdated Show resolved Hide resolved
pom.xml Show resolved Hide resolved
Signed-off-by: Scott M Stark <starksm64@gmail.com>
Signed-off-by: Scott M Stark <starksm64@gmail.com>
Signed-off-by: Scott M Stark <starksm64@gmail.com>
Signed-off-by: Scott M Stark <starksm64@gmail.com>
@starksm64
Copy link
Member Author

Ok, CI is back to passing

@bartoszmajsak
Copy link
Member

Is it intended to be a support branch with not so many changes in the future or do we expect merging back stuff from ongoing development? If the latter it might be good to think about the approach here (ideally automatic).

@starksm64
Copy link
Member Author

I expect very little ongoing development in this glassfish6 branch.

@hantsy
Copy link
Member

hantsy commented Apr 21, 2022

Merge this PR to upstream glassfish6(not master) branch and release a preview for Glassfish 6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants